Re: [Mesa-dev] [PATCH] i965: Only set key->flat_shade if COL0/COL1 are written.

2017-08-23 Thread Kenneth Graunke
On Wednesday, August 23, 2017 12:04:40 PM PDT Ilia Mirkin wrote: > You might consider also including whether the interpolation method was > forced or not. i.e. if you have > > flat varying vec4 gl_Color; > > then it doesn't matter whether shade model is flat or not, it'll be > interpolated as fla

Re: [Mesa-dev] [PATCH] i965: Only set key->flat_shade if COL0/COL1 are written.

2017-08-23 Thread Ilia Mirkin
You might consider also including whether the interpolation method was forced or not. i.e. if you have flat varying vec4 gl_Color; then it doesn't matter whether shade model is flat or not, it'll be interpolated as flat. (Same with the other qualifiers made available in GL 3.0.) So you only have

Re: [Mesa-dev] [PATCH] i965: Only set key->flat_shade if COL0/COL1 are written.

2017-08-22 Thread Timothy Arceri
Seems reasonable: Reviewed-by: Timothy Arceri On 23/08/17 12:19, Kenneth Graunke wrote: This may reduce some recompiles. --- src/mesa/drivers/dri/i965/brw_wm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_wm.c b/src/mesa/drivers/dri/i

[Mesa-dev] [PATCH] i965: Only set key->flat_shade if COL0/COL1 are written.

2017-08-22 Thread Kenneth Graunke
This may reduce some recompiles. --- src/mesa/drivers/dri/i965/brw_wm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_wm.c b/src/mesa/drivers/dri/i965/brw_wm.c index c9c45045902..e1555d60c56 100644 --- a/src/mesa/drivers/dri/i965/brw_wm.c +++