Re: [Mesa-dev] [PATCH] i965: Free dead GLSL IR one last time.

2015-04-06 Thread Ian Romanick
On 04/02/2015 10:55 AM, Thomas Helland wrote: > This reminds me of a patch Eric wrote that probably > fell through the cracks when he migrated jobs: > > https://freedesktop.org/patch/26778/ > "Free the compiled shader IR after it has been linked" There's a pretty significant bug triggered by that

Re: [Mesa-dev] [PATCH] i965: Free dead GLSL IR one last time.

2015-04-02 Thread Kenneth Graunke
On Thursday, April 02, 2015 10:36:44 AM Jason Ekstrand wrote: > On Thu, Apr 2, 2015 at 2:04 AM, Kenneth Graunke wrote: > > While working on NIR's memory allocation model, I realized the GLSL IR > > memory model was broken. > > > > During glCompileShader, we allocate everything out of the > > _mesa

Re: [Mesa-dev] [PATCH] i965: Free dead GLSL IR one last time.

2015-04-02 Thread Thomas Helland
This reminds me of a patch Eric wrote that probably fell through the cracks when he migrated jobs: https://freedesktop.org/patch/26778/ "Free the compiled shader IR after it has been linked" It got an R-B, but seems like it never made it to upstream. I don't know if it still applies to the way th

Re: [Mesa-dev] [PATCH] i965: Free dead GLSL IR one last time.

2015-04-02 Thread Jason Ekstrand
On Thu, Apr 2, 2015 at 2:04 AM, Kenneth Graunke wrote: > While working on NIR's memory allocation model, I realized the GLSL IR > memory model was broken. > > During glCompileShader, we allocate everything out of the > _mesa_glsl_parse_state context, and reparent it to gl_shader at the end. > > Du

[Mesa-dev] [PATCH] i965: Free dead GLSL IR one last time.

2015-04-02 Thread Kenneth Graunke
While working on NIR's memory allocation model, I realized the GLSL IR memory model was broken. During glCompileShader, we allocate everything out of the _mesa_glsl_parse_state context, and reparent it to gl_shader at the end. During glLinkProgram, we allocate everything out of a temporary contex