Re: [Mesa-dev] [PATCH] i965: Fix union usage for GCC <= 4.6.

2014-12-08 Thread Matt Turner
On Fri, Dec 5, 2014 at 6:18 PM, Vinson Lee wrote: > This patch fixes this build error with GCC <= 4.6. Change GCC to G++ here and in the commit message, and Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists

Re: [Mesa-dev] [PATCH] i965: Fix union usage for GCC <= 4.6.

2014-12-08 Thread Eero Tamminen
Hi, On 12/06/2014 05:46 AM, Jonathan Gray wrote: Along with the ABI-check scripts it seems at the very least all occurances of "#!/bin/bash" should be changed to "#!/usr/bin/env bash" if they are actually bash specific. Debian's devscripts package's checkbashisms checker tells about Bash needs

Re: [Mesa-dev] [PATCH] i965: Fix union usage for GCC <= 4.6.

2014-12-05 Thread Jonathan Gray
On Fri, Dec 05, 2014 at 06:56:27PM -0800, Matt Turner wrote: > On Fri, Dec 5, 2014 at 6:18 PM, Vinson Lee wrote: > > This patch fixes this build error with GCC <= 4.6. > > > > CXXtest_vf_float_conversions.o > > test_vf_float_conversions.cpp: In function ???unsigned int f2u(float)???: > > tes

Re: [Mesa-dev] [PATCH] i965: Fix union usage for GCC <= 4.6.

2014-12-05 Thread Ben Widawsky
On Fri, Dec 05, 2014 at 06:56:27PM -0800, Matt Turner wrote: > On Fri, Dec 5, 2014 at 6:18 PM, Vinson Lee wrote: > > This patch fixes this build error with GCC <= 4.6. > > > > CXXtest_vf_float_conversions.o > > test_vf_float_conversions.cpp: In function ‘unsigned int f2u(float)’: > > test_vf

Re: [Mesa-dev] [PATCH] i965: Fix union usage for GCC <= 4.6.

2014-12-05 Thread Matt Turner
On Fri, Dec 5, 2014 at 6:18 PM, Vinson Lee wrote: > This patch fixes this build error with GCC <= 4.6. > > CXXtest_vf_float_conversions.o > test_vf_float_conversions.cpp: In function ‘unsigned int f2u(float)’: > test_vf_float_conversions.cpp:63:20: error: expected primary-expression > befor

[Mesa-dev] [PATCH] i965: Fix union usage for GCC <= 4.6.

2014-12-05 Thread Vinson Lee
This patch fixes this build error with GCC <= 4.6. CXXtest_vf_float_conversions.o test_vf_float_conversions.cpp: In function ‘unsigned int f2u(float)’: test_vf_float_conversions.cpp:63:20: error: expected primary-expression before ‘.’ token Bugzilla: https://bugs.freedesktop.org/show_bug.c