Re: [Mesa-dev] [PATCH] i965: Fix undefined df bits in brw_reg comparisons.

2016-05-17 Thread Emil Velikov
On 16 May 2016 at 05:33, Kenneth Graunke wrote: > On Saturday, May 14, 2016 2:42:20 PM PDT Emil Velikov wrote: >> Hi Ken, >> >> On 14 May 2016 at 01:44, Kenneth Graunke wrote: >> > Commit 5310bca024f77da40ea6f4c275455f9cb0528f9e added a new "double df" >> > field to the brw_reg struct, adding an

Re: [Mesa-dev] [PATCH] i965: Fix undefined df bits in brw_reg comparisons.

2016-05-16 Thread Matt Turner
On Fri, May 13, 2016 at 5:44 PM, Kenneth Graunke wrote: > Commit 5310bca024f77da40ea6f4c275455f9cb0528f9e added a new "double df" > field to the brw_reg struct, adding an extra 4 bytes of data that isn't > usually initialized (or may contain irrelevant garbage if the struct is > mutated). This me

Re: [Mesa-dev] [PATCH] i965: Fix undefined df bits in brw_reg comparisons.

2016-05-15 Thread Kenneth Graunke
On Saturday, May 14, 2016 2:42:20 PM PDT Emil Velikov wrote: > Hi Ken, > > On 14 May 2016 at 01:44, Kenneth Graunke wrote: > > Commit 5310bca024f77da40ea6f4c275455f9cb0528f9e added a new "double df" > > field to the brw_reg struct, adding an extra 4 bytes of data that isn't > > usually initialize

Re: [Mesa-dev] [PATCH] i965: Fix undefined df bits in brw_reg comparisons.

2016-05-14 Thread Emil Velikov
Hi Ken, On 14 May 2016 at 01:44, Kenneth Graunke wrote: > Commit 5310bca024f77da40ea6f4c275455f9cb0528f9e added a new "double df" > field to the brw_reg struct, adding an extra 4 bytes of data that isn't > usually initialized (or may contain irrelevant garbage if the struct is > mutated). This m

Re: [Mesa-dev] [PATCH] i965: Fix undefined df bits in brw_reg comparisons.

2016-05-14 Thread Samuel Iglesias Gonsálvez
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 With Curro's comment addressed, Reviewed-by: Samuel Iglesias Gonsálvez On 14/05/16 02:44, Kenneth Graunke wrote: > Commit 5310bca024f77da40ea6f4c275455f9cb0528f9e added a new "double > df" field to the brw_reg struct, adding an extra 4 bytes of da

Re: [Mesa-dev] [PATCH] i965: Fix undefined df bits in brw_reg comparisons.

2016-05-13 Thread Kenneth Graunke
On Friday, May 13, 2016 5:58:25 PM PDT Francisco Jerez wrote: > Kenneth Graunke writes: > > > Commit 5310bca024f77da40ea6f4c275455f9cb0528f9e added a new "double df" > > field to the brw_reg struct, adding an extra 4 bytes of data that isn't > > usually initialized (or may contain irrelevant garb

Re: [Mesa-dev] [PATCH] i965: Fix undefined df bits in brw_reg comparisons.

2016-05-13 Thread Francisco Jerez
Kenneth Graunke writes: > Commit 5310bca024f77da40ea6f4c275455f9cb0528f9e added a new "double df" > field to the brw_reg struct, adding an extra 4 bytes of data that isn't > usually initialized (or may contain irrelevant garbage if the struct is > mutated). This means that it's no longer safe to

[Mesa-dev] [PATCH] i965: Fix undefined df bits in brw_reg comparisons.

2016-05-13 Thread Kenneth Graunke
Commit 5310bca024f77da40ea6f4c275455f9cb0528f9e added a new "double df" field to the brw_reg struct, adding an extra 4 bytes of data that isn't usually initialized (or may contain irrelevant garbage if the struct is mutated). This means that it's no longer safe to memcmp(). Instead, add a brw_reg