Re: [Mesa-dev] [PATCH] i965: Fix cube array coordinate normalization

2013-09-25 Thread Chris Forbes
Fixed and landed on master now. On Mon, Sep 23, 2013 at 8:05 AM, Eric Anholt wrote: > Chris Forbes writes: > >> Hardware requires the magnitude of the largest component to not exceed >> 1; brw_cubemap_normalize ensures that this is the case. >> >> Unfortunately, we would previously multiply the

Re: [Mesa-dev] [PATCH] i965: Fix cube array coordinate normalization

2013-09-22 Thread Eric Anholt
Chris Forbes writes: > Hardware requires the magnitude of the largest component to not exceed > 1; brw_cubemap_normalize ensures that this is the case. > > Unfortunately, we would previously multiply the array index for cube > arrays by the normalization factor. The incorrect array index would th

[Mesa-dev] [PATCH] i965: Fix cube array coordinate normalization

2013-09-15 Thread Chris Forbes
Hardware requires the magnitude of the largest component to not exceed 1; brw_cubemap_normalize ensures that this is the case. Unfortunately, we would previously multiply the array index for cube arrays by the normalization factor. The incorrect array index would then cause the sampler to attempt