Re: [Mesa-dev] [PATCH] i965: Fix ARB_indirect_parameters logic.

2017-10-31 Thread Manolova, Plamena
Thank you for helping me out with this Ken! On Tue, Oct 31, 2017 at 3:50 AM, Kenneth Graunke wrote: > On Monday, October 30, 2017 2:14:24 PM PDT Plamena Manolova wrote: > > This patch modifies the ARB_indirect_parameters logic in > > brw_draw_prims, so that our implementation isn't affected if >

Re: [Mesa-dev] [PATCH] i965: Fix ARB_indirect_parameters logic.

2017-10-30 Thread Kenneth Graunke
On Monday, October 30, 2017 2:14:24 PM PDT Plamena Manolova wrote: > This patch modifies the ARB_indirect_parameters logic in > brw_draw_prims, so that our implementation isn't affected if > another application attempts to use predicates. Previously we > were using a predicate with a DELTAS_EQUAL c

[Mesa-dev] [PATCH] i965: Fix ARB_indirect_parameters logic.

2017-10-30 Thread Plamena Manolova
This patch modifies the ARB_indirect_parameters logic in brw_draw_prims, so that our implementation isn't affected if another application attempts to use predicates. Previously we were using a predicate with a DELTAS_EQUAL comparison operation and relying on the MI_PREDICATE_DATA register being 0.

Re: [Mesa-dev] [PATCH] i965: Fix ARB_indirect_parameters logic.

2017-10-26 Thread Kenneth Graunke
On Thursday, October 26, 2017 4:24:10 AM PDT Manolova, Plamena wrote: [snip] > After taking another look you're absolutely right. For some reason > propagating the predicates like this didn't occur to me. > If we use this approach couldn't we get away with just having one predicate > per draw call?

Re: [Mesa-dev] [PATCH] i965: Fix ARB_indirect_parameters logic.

2017-10-26 Thread Manolova, Plamena
Thank you for reviewing Ken! On Thu, Oct 26, 2017 at 5:14 AM, Kenneth Graunke wrote: > On Wednesday, October 25, 2017 9:54:46 AM PDT Plamena Manolova wrote: > > This patch modifies the ARB_indirect_parameters logic in > > brw_draw_prims, so that our implementation isn't affected if > > another a

Re: [Mesa-dev] [PATCH] i965: Fix ARB_indirect_parameters logic.

2017-10-25 Thread Kenneth Graunke
On Wednesday, October 25, 2017 9:54:46 AM PDT Plamena Manolova wrote: > This patch modifies the ARB_indirect_parameters logic in > brw_draw_prims, so that our implementation isn't affected if > another application attempts to use predicates. Previously we > were using a predicate with a DELTAS_EQUA

[Mesa-dev] [PATCH] i965: Fix ARB_indirect_parameters logic.

2017-10-25 Thread Plamena Manolova
This patch modifies the ARB_indirect_parameters logic in brw_draw_prims, so that our implementation isn't affected if another application attempts to use predicates. Previously we were using a predicate with a DELTAS_EQUAL comparison operation and relying on the MI_PREDICATE_DATA register being 0.