Re: [Mesa-dev] [PATCH] i965: Don't leak gen_spec from INTEL_DEBUG=bat handling.

2017-03-22 Thread Kenneth Graunke
On Wednesday, March 22, 2017 10:35:50 PM PDT Jason Ekstrand wrote: > Is the whole spec really a flat thing you an free with a single free()? If > not, maybe we should consider pulling in ralloc to help out. You're right, this patch is totally bogus. ralloc sounds appropriate. signature.asc De

Re: [Mesa-dev] [PATCH] i965: Don't leak gen_spec from INTEL_DEBUG=bat handling.

2017-03-22 Thread Jason Ekstrand
Is the whole spec really a flat thing you an free with a single free()? If not, maybe we should consider pulling in ralloc to help out. On March 22, 2017 22:25:40 Kenneth Graunke wrote: We were loading the XML descriptions on every batchbuffer and leaking them each time. Now, we load it on

[Mesa-dev] [PATCH] i965: Don't leak gen_spec from INTEL_DEBUG=bat handling.

2017-03-22 Thread Kenneth Graunke
We were loading the XML descriptions on every batchbuffer and leaking them each time. Now, we load it once at screen init time and free it at screen destroy time. Caught by Coverity. CID: 1403203 --- src/mesa/drivers/dri/i965/intel_batchbuffer.c | 2 +- src/mesa/drivers/dri/i965/intel_screen.c