FYI, I don't consider this patch to be the correct approach for solving the
problem. There are other callers that could run into trouble; in
particular any super-small blits like 0.5-wide. I think we likely want to
either do a full audit of all blorp_blit callers or somehow solve it in
blorp_blit
Hi Jason,
Looks like there is an issue with the float comparison. It works perfectly
fine for me if it is compared with some precision:
if( (fabsf(*dstX1 - *dstX0) < 1e-8F) || (fabsf(*dstY1 - *dstY0) < 1e-8F) ) {
return true;
пн, 1 окт. 2018 г. в 19:24, Eric Engestrom :
> On Monday, 201
On Monday, 2018-10-01 11:04:09 +0200, Juan A. Suarez Romero wrote:
> On Tue, 2018-09-11 at 11:15 -0500, Jason Ekstrand wrote:
> > Cc: mesa-sta...@lists.freedesktop.org
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107892
> > ---
> > src/mesa/drivers/dri/i965/brw_meta_util.c | 3 +++
>
Hi Jason,
I'm still getting crash with this patch when run conformance test in the
firefox.
Assert is triggered during following call:
glBlitFramebuffer(srcX0 = -1, srcY0 = -1, srcX1 = 2147483646, srcY1 =
2147483646, dstX0 = 0, dstY0 = 0, dstX1 = 8, dstY1 = 8, mask =
GL_COLOR_BUFFER_BIT, filter =
On Tue, 2018-09-11 at 11:15 -0500, Jason Ekstrand wrote:
> Cc: mesa-sta...@lists.freedesktop.org
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107892
> ---
> src/mesa/drivers/dri/i965/brw_meta_util.c | 3 +++
> 1 file changed, 3 insertions(+)
>
This has been reviewed, but not pushed y
Reviewed-by: Jordan Justen
On 2018-09-11 09:15:38, Jason Ekstrand wrote:
> Cc: mesa-sta...@lists.freedesktop.org
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107892
> ---
> src/mesa/drivers/dri/i965/brw_meta_util.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/src/mesa
Cc: mesa-sta...@lists.freedesktop.org
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107892
---
src/mesa/drivers/dri/i965/brw_meta_util.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_meta_util.c
b/src/mesa/drivers/dri/i965/brw_meta_util.c
index 908b
