Re: [Mesa-dev] [PATCH] i965: Correct constant buffer MOCS

2015-06-03 Thread Ben Widawsky
On Wed, Jun 03, 2015 at 12:20:09AM -0700, Kenneth Graunke wrote: > On Tuesday, June 02, 2015 11:41:56 PM Ben Widawsky wrote: > > On Tue, 02 Jun 2015 20:32:13 -0700 > > Kenneth Graunke wrote: > > > > > On Tuesday, June 02, 2015 08:07:50 PM Ben Widawsky wrote: > > > > I'm very confused here. It see

Re: [Mesa-dev] [PATCH] i965: Correct constant buffer MOCS

2015-06-03 Thread Kenneth Graunke
On Tuesday, June 02, 2015 11:41:56 PM Ben Widawsky wrote: > On Tue, 02 Jun 2015 20:32:13 -0700 > Kenneth Graunke wrote: > > > On Tuesday, June 02, 2015 08:07:50 PM Ben Widawsky wrote: > > > I'm very confused here. It seems pretty clear that since the > > > command has been introduced with support

Re: [Mesa-dev] [PATCH] i965: Correct constant buffer MOCS

2015-06-02 Thread Ben Widawsky
On Tue, 02 Jun 2015 20:32:13 -0700 Kenneth Graunke wrote: > On Tuesday, June 02, 2015 08:07:50 PM Ben Widawsky wrote: > > I'm very confused here. It seems pretty clear that since the > > command has been introduced with support for MOCS, MOCS lives at > > bit 8 of dword 0 for all constant buffers

Re: [Mesa-dev] [PATCH] i965: Correct constant buffer MOCS

2015-06-02 Thread Kenneth Graunke
On Tuesday, June 02, 2015 08:07:50 PM Ben Widawsky wrote: > I'm very confused here. It seems pretty clear that since the command has been > introduced with support for MOCS, MOCS lives at bit 8 of dword 0 for all > constant buffers. The error has existed since forever AFAICT. > > No piglit regress

[Mesa-dev] [PATCH] i965: Correct constant buffer MOCS

2015-06-02 Thread Ben Widawsky
I'm very confused here. It seems pretty clear that since the command has been introduced with support for MOCS, MOCS lives at bit 8 of dword 0 for all constant buffers. The error has existed since forever AFAICT. No piglit regressions or fixes: http://otc-mesa-ci.jf.intel.com/view/dev/job/bwidawsk