Re: [Mesa-dev] [PATCH] i965: Avoid segfault in gen6_upload_state

2013-02-22 Thread Ian Romanick
On 02/22/2013 05:20 PM, Ian Romanick wrote: On 02/22/2013 05:15 PM, Carl Worth wrote: Ian Romanick writes: Also, the correct way to say this is: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=59445 Thanks. I missed that on this patch, but will get it right in the future. ctx->Draw

Re: [Mesa-dev] [PATCH] i965: Avoid segfault in gen6_upload_state

2013-02-22 Thread Ian Romanick
On 02/22/2013 05:15 PM, Carl Worth wrote: Ian Romanick writes: Also, the correct way to say this is: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=59445 Thanks. I missed that on this patch, but will get it right in the future. ctx->DrawBuffer->Visual doesn't know about your alpha

Re: [Mesa-dev] [PATCH] i965: Avoid segfault in gen6_upload_state

2013-02-22 Thread Carl Worth
Ian Romanick writes: > Also, the correct way to say this is: > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=59445 Thanks. I missed that on this patch, but will get it right in the future. >> ctx->DrawBuffer->Visual doesn't know about your alpha bits when you have >> MRT some with alp

Re: [Mesa-dev] [PATCH] i965: Avoid segfault in gen6_upload_state

2013-02-22 Thread Ian Romanick
On 02/20/2013 05:34 PM, Eric Anholt wrote: Ian Romanick writes: On 02/19/2013 04:27 PM, Carl Worth wrote: This fixes a bug introduced in commit 258453716f001eab1288d99765213 and triggered whenever "rb" is NULL. Fixes bug #59445: [SNB/IVB/HSW Bisected]Oglc draw-buffers2(advanced.blen

Re: [Mesa-dev] [PATCH] i965: Avoid segfault in gen6_upload_state

2013-02-20 Thread Eric Anholt
Ian Romanick writes: > On 02/19/2013 04:27 PM, Carl Worth wrote: >> This fixes a bug introduced in commit 258453716f001eab1288d99765213 and >> triggered whenever "rb" is NULL. >> >> Fixes bug #59445: >> >> [SNB/IVB/HSW Bisected]Oglc draw-buffers2(advanced.blending.none) >> segfault >>

Re: [Mesa-dev] [PATCH] i965: Avoid segfault in gen6_upload_state

2013-02-20 Thread Carl Worth
This fixes a bug introduced in commit 258453716f001eab1288d99765213 and triggered whenever "rb" is NULL. This uses the same condition as similar code in brw_cc.c (used for older hardware). Fixes bug #59445: [SNB/IVB/HSW Bisected]Oglc draw-buffers2(advanced.blending.none) segfault

Re: [Mesa-dev] [PATCH] i965: Avoid segfault in gen6_upload_state

2013-02-19 Thread Ian Romanick
On 02/19/2013 04:27 PM, Carl Worth wrote: This fixes a bug introduced in commit 258453716f001eab1288d99765213 and triggered whenever "rb" is NULL. Fixes bug #59445: [SNB/IVB/HSW Bisected]Oglc draw-buffers2(advanced.blending.none) segfault https://bugs.freedesktop.org/show_bug.c

[Mesa-dev] [PATCH] i965: Avoid segfault in gen6_upload_state

2013-02-19 Thread Carl Worth
This fixes a bug introduced in commit 258453716f001eab1288d99765213 and triggered whenever "rb" is NULL. Fixes bug #59445: [SNB/IVB/HSW Bisected]Oglc draw-buffers2(advanced.blending.none) segfault https://bugs.freedesktop.org/show_bug.cgi?id=59445 --- I don't know under what con