Re: [Mesa-dev] [PATCH] i965/vec4: Fix liveness analysis with BRW_OPCODE_SEL

2015-07-20 Thread Kenneth Graunke
On Monday, July 20, 2015 03:14:14 PM Iago Toral Quiroga wrote: > We only consider a vgrf defined by a given block if the block writes to it > unconditionally. So far we have been checking this by testing that the > instruction is not predicated, however, in the case of BRW_OPCODE_SEL, > the predica

Re: [Mesa-dev] [PATCH] i965/vec4: Fix liveness analysis with BRW_OPCODE_SEL

2015-07-20 Thread Francisco Jerez
Iago Toral Quiroga writes: > We only consider a vgrf defined by a given block if the block writes to it > unconditionally. So far we have been checking this by testing that the > instruction is not predicated, however, in the case of BRW_OPCODE_SEL, > the predication is used to select the value t

[Mesa-dev] [PATCH] i965/vec4: Fix liveness analysis with BRW_OPCODE_SEL

2015-07-20 Thread Iago Toral Quiroga
We only consider a vgrf defined by a given block if the block writes to it unconditionally. So far we have been checking this by testing that the instruction is not predicated, however, in the case of BRW_OPCODE_SEL, the predication is used to select the value to write, not to decide if the write i