Re: [Mesa-dev] [PATCH] i965/hiz: Don't bind GL_DRAW_FRAMEBUFFER on GLES

2012-01-13 Thread Chad Versace
On 01/12/2012 02:50 PM, Ian Romanick wrote: > On 01/12/2012 05:44 AM, Neil Roberts wrote: >> Hi, >> >> Chad Versace wrote: >> >>> [chad]: Make comments more concise. Change the if-condition to be >>> compatible with a core context, which may not advertise old extensions. >> >> The change to the if

Re: [Mesa-dev] [PATCH] i965/hiz: Don't bind GL_DRAW_FRAMEBUFFER on GLES

2012-01-12 Thread Ian Romanick
On 01/12/2012 05:44 AM, Neil Roberts wrote: Hi, Chad Versace wrote: [chad]: Make comments more concise. Change the if-condition to be compatible with a core context, which may not advertise old extensions. The change to the if-condition breaks the patch. The problem is this bit of code in f

Re: [Mesa-dev] [PATCH] i965/hiz: Don't bind GL_DRAW_FRAMEBUFFER on GLES

2012-01-12 Thread Eric Anholt
On Thu, 12 Jan 2012 13:44:12 +, Neil Roberts wrote: > Hi, > > Chad Versace wrote: > > > [chad]: Make comments more concise. Change the if-condition to be > > compatible with a core context, which may not advertise old extensions. I think when we do core contexts, we'll want to keep flaggin

Re: [Mesa-dev] [PATCH] i965/hiz: Don't bind GL_DRAW_FRAMEBUFFER on GLES

2012-01-12 Thread Neil Roberts
Hi, Chad Versace wrote: > [chad]: Make comments more concise. Change the if-condition to be > compatible with a core context, which may not advertise old extensions. The change to the if-condition breaks the patch. The problem is this bit of code in fbobject.c: static struct gl_framebuffer * g

[Mesa-dev] [PATCH] i965/hiz: Don't bind GL_DRAW_FRAMEBUFFER on GLES

2012-01-11 Thread Chad Versace
From: Neil Roberts When using Mesa with a GLES API, calling _mesa_FramebufferRenderbuffer with GL_DRAW_FRAMEBUFFER will report a 'user error' because get_framebuffer_target validates that this enum from the framebuffer blit extension is only used on GL. To work around it this patch makes it use t