Re: [Mesa-dev] [PATCH] i965/fs: Fix Sandybridge regressions from SEL optimization.

2013-08-15 Thread Ian Romanick
On 08/13/2013 05:57 PM, Kenneth Graunke wrote: On 08/13/2013 05:49 PM, Ian Romanick wrote: On 08/13/2013 04:47 PM, Kenneth Graunke wrote: Sandybridge is the only platform that supports an IF instruction with an embedded comparison. In this case, we need to emit a CMP to go along with the SEL.

Re: [Mesa-dev] [PATCH] i965/fs: Fix Sandybridge regressions from SEL optimization.

2013-08-15 Thread Anuj Phogat
On Tue, Aug 13, 2013 at 5:57 PM, Kenneth Graunke wrote: > On 08/13/2013 05:49 PM, Ian Romanick wrote: >> >> On 08/13/2013 04:47 PM, Kenneth Graunke wrote: >>> >>> Sandybridge is the only platform that supports an IF instruction >>> with an embedded comparison. In this case, we need to emit a CMP

Re: [Mesa-dev] [PATCH] i965/fs: Fix Sandybridge regressions from SEL optimization.

2013-08-15 Thread Matt Turner
On Tue, Aug 13, 2013 at 4:47 PM, Kenneth Graunke wrote: > Sandybridge is the only platform that supports an IF instruction > with an embedded comparison. In this case, we need to emit a CMP > to go along with the SEL. > > Fixes regressions in Piglit's glsl-fs-atan-3, fs-unpackHalf2x16, > fs-facef

Re: [Mesa-dev] [PATCH] i965/fs: Fix Sandybridge regressions from SEL optimization.

2013-08-13 Thread Kenneth Graunke
On 08/13/2013 05:49 PM, Ian Romanick wrote: On 08/13/2013 04:47 PM, Kenneth Graunke wrote: Sandybridge is the only platform that supports an IF instruction with an embedded comparison. In this case, we need to emit a CMP to go along with the SEL. Fixes regressions in Piglit's glsl-fs-atan-3, f

Re: [Mesa-dev] [PATCH] i965/fs: Fix Sandybridge regressions from SEL optimization.

2013-08-13 Thread Ian Romanick
On 08/13/2013 04:47 PM, Kenneth Graunke wrote: Sandybridge is the only platform that supports an IF instruction with an embedded comparison. In this case, we need to emit a CMP to go along with the SEL. Fixes regressions in Piglit's glsl-fs-atan-3, fs-unpackHalf2x16, fs-faceforward-float-float-

[Mesa-dev] [PATCH] i965/fs: Fix Sandybridge regressions from SEL optimization.

2013-08-13 Thread Kenneth Graunke
Sandybridge is the only platform that supports an IF instruction with an embedded comparison. In this case, we need to emit a CMP to go along with the SEL. Fixes regressions in Piglit's glsl-fs-atan-3, fs-unpackHalf2x16, fs-faceforward-float-float-float, isinf-and-isnan fs_basic, and isinf-and-is