Re: [Mesa-dev] [PATCH] i965/fs: Drop the emit(fs_inst) overload.

2014-02-22 Thread Pohjolainen, Topi
On Fri, Feb 21, 2014 at 03:23:42PM -0800, Kenneth Graunke wrote: > Using this emit function implicitly creates three copies, which > is pointlessly inefficient. > > 1. Code creates the original instruction. > 2. Calling emit(fs_inst) copies it into the function. > 3. It then allocates a new fs_ins

Re: [Mesa-dev] [PATCH] i965/fs: Drop the emit(fs_inst) overload.

2014-02-21 Thread Matt Turner
Reviewed-by: Matt Turner I'll replace 13/19 with *this* patch. :) ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] i965/fs: Drop the emit(fs_inst) overload.

2014-02-21 Thread Kenneth Graunke
Using this emit function implicitly creates three copies, which is pointlessly inefficient. 1. Code creates the original instruction. 2. Calling emit(fs_inst) copies it into the function. 3. It then allocates a new fs_inst and copies it into that. The second could be eliminated by changing the si