Re: [Mesa-dev] [PATCH] gm107/ir: fix compile time warning in getTEXSMask

2018-11-07 Thread Karol Herbst
On Wed, Nov 7, 2018 at 3:21 PM Ilia Mirkin wrote: > > Reviewed-by: Ilia Mirkin > > Although I'd rather the return go into the "default:" case, after the > assert, which is the reason for the warning. sure, I'll move it. > On Wed, Nov 7, 2018 at 7:50 AM Karol Herbst wrote: > > > > In function '

Re: [Mesa-dev] [PATCH] gm107/ir: fix compile time warning in getTEXSMask

2018-11-07 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin Although I'd rather the return go into the "default:" case, after the assert, which is the reason for the warning. On Wed, Nov 7, 2018 at 7:50 AM Karol Herbst wrote: > > In function 'uint8_t nv50_ir::getTEXSMask(uint8_t)': > warning: control reaches end of non-void funct

[Mesa-dev] [PATCH] gm107/ir: fix compile time warning in getTEXSMask

2018-11-07 Thread Karol Herbst
In function 'uint8_t nv50_ir::getTEXSMask(uint8_t)': warning: control reaches end of non-void function [-Wreturn-type] Reported-by: Moiman@freenode Fixes: f821e80213e38e93f96255b3deacb737a600ed40 "gm107/ir: use scalar tex instructions where possible" Signed-off-by: Karol Herbst --- src/ga