Re: [Mesa-dev] [PATCH] glxproto: make GLX swap event struct match spec

2011-05-04 Thread Jesse Barnes
On Wed, 4 May 2011 17:49:37 -0700 Jesse Barnes wrote: > How about you look at git and see what happened last time? > > We added some dri2 proto requests, and people wanted to build with old > versions w/o the new requests. So they added some ifdefs but didn't > check all the combos (now not just

Re: [Mesa-dev] [PATCH] glxproto: make GLX swap event struct match spec

2011-05-04 Thread Jesse Barnes
On Thu, 05 May 2011 09:32:46 +1000 Dave Airlie wrote: > On Wed, 2011-05-04 at 16:16 -0700, Jesse Barnes wrote: > > On Wed, 04 May 2011 15:17:31 -0700 > > Ian Romanick wrote: > > > > > -BEGIN PGP SIGNED MESSAGE- > > > Hash: SHA1 > > > > > > On 05/03/2011 12:21 PM, Jesse Barnes wrote: >

Re: [Mesa-dev] [PATCH] glxproto: make GLX swap event struct match spec

2011-05-04 Thread Dave Airlie
On Wed, 2011-05-04 at 16:16 -0700, Jesse Barnes wrote: > On Wed, 04 May 2011 15:17:31 -0700 > Ian Romanick wrote: > > > -BEGIN PGP SIGNED MESSAGE- > > Hash: SHA1 > > > > On 05/03/2011 12:21 PM, Jesse Barnes wrote: > > > We only spec a 32 bit swap count, so drop the high sbc field. > > >

Re: [Mesa-dev] [PATCH] glxproto: make GLX swap event struct match spec

2011-05-04 Thread Jesse Barnes
On Wed, 4 May 2011 16:16:37 -0700 Jesse Barnes wrote: > On Wed, 04 May 2011 15:17:31 -0700 > Ian Romanick wrote: > > > -BEGIN PGP SIGNED MESSAGE- > > Hash: SHA1 > > > > On 05/03/2011 12:21 PM, Jesse Barnes wrote: > > > We only spec a 32 bit swap count, so drop the high sbc field. > > >

Re: [Mesa-dev] [PATCH] glxproto: make GLX swap event struct match spec

2011-05-04 Thread Jesse Barnes
On Wed, 04 May 2011 15:17:31 -0700 Ian Romanick wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 05/03/2011 12:21 PM, Jesse Barnes wrote: > > We only spec a 32 bit swap count, so drop the high sbc field. > > > > Signed-off-by: Jesse Barnes > > Is there any way we could do this

Re: [Mesa-dev] [PATCH] glxproto: make GLX swap event struct match spec

2011-05-04 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/03/2011 12:21 PM, Jesse Barnes wrote: > We only spec a 32 bit swap count, so drop the high sbc field. > > Signed-off-by: Jesse Barnes Is there any way we could do this and NOT break building older versions of Mesa? I'd like to be able to buil

Re: [Mesa-dev] [PATCH] glxproto: make GLX swap event struct match spec

2011-05-04 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/03/2011 02:08 PM, Jesse Barnes wrote: > On Tue, 3 May 2011 14:02:31 -0700 > Jesse Barnes wrote: > >> On Tue, 03 May 2011 13:54:38 -0700 >> Keith Packard wrote: >> >>> On Tue, 3 May 2011 12:21:24 -0700, Jesse Barnes >>> wrote: >>> We on

Re: [Mesa-dev] [PATCH] glxproto: make GLX swap event struct match spec

2011-05-03 Thread Jesse Barnes
On Tue, 03 May 2011 14:15:30 -0700 Keith Packard wrote: > On Tue, 3 May 2011 14:08:58 -0700, Jesse Barnes > wrote: > > > Fixed version below. > > Reviewed-by: Keith Packard > > (assuming that the GLX protocol specification gets updated to match :-) Yeah, Ian is fixing up the padding there

Re: [Mesa-dev] [PATCH] glxproto: make GLX swap event struct match spec

2011-05-03 Thread Keith Packard
On Tue, 3 May 2011 14:08:58 -0700, Jesse Barnes wrote: > Fixed version below. Reviewed-by: Keith Packard (assuming that the GLX protocol specification gets updated to match :-) -- keith.pack...@intel.com pgpmw6kAybqOk.pgp Description: PGP signature

Re: [Mesa-dev] [PATCH] glxproto: make GLX swap event struct match spec

2011-05-03 Thread Jesse Barnes
On Tue, 3 May 2011 14:02:31 -0700 Jesse Barnes wrote: > On Tue, 03 May 2011 13:54:38 -0700 > Keith Packard wrote: > > > On Tue, 3 May 2011 12:21:24 -0700, Jesse Barnes > > wrote: > > > > > We only spec a 32 bit swap count, so drop the high sbc field. > > > > You're missing the explicit 16-

Re: [Mesa-dev] [PATCH] glxproto: make GLX swap event struct match spec

2011-05-03 Thread Jesse Barnes
On Tue, 03 May 2011 13:54:38 -0700 Keith Packard wrote: > On Tue, 3 May 2011 12:21:24 -0700, Jesse Barnes > wrote: > > > We only spec a 32 bit swap count, so drop the high sbc field. > > You're missing the explicit 16-bit padding field after 'event_type' > > The documented encoding > http:/

Re: [Mesa-dev] [PATCH] glxproto: make GLX swap event struct match spec

2011-05-03 Thread Keith Packard
On Tue, 3 May 2011 12:21:24 -0700, Jesse Barnes wrote: > We only spec a 32 bit swap count, so drop the high sbc field. You're missing the explicit 16-bit padding field after 'event_type' The documented encoding http://www.opengl.org/registry/specs/INTEL/swap_event.txt needs to be fixed to mat

[Mesa-dev] [PATCH] glxproto: make GLX swap event struct match spec

2011-05-03 Thread Jesse Barnes
We only spec a 32 bit swap count, so drop the high sbc field. Signed-off-by: Jesse Barnes --- configure.ac |2 +- glxproto.h |3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index d88e6df..a3047e4 100644 --- a/configure.ac +++ b/configu