Re: [Mesa-dev] [PATCH] glx: Fix __glXWireToEvent for BufferSwapComplete

2015-08-05 Thread Eric Anholt
Adam Jackson writes: > On Tue, 2015-08-04 at 19:38 -0700, Eric Anholt wrote: > >> In the Pbuffer path, we get serial from awire. Why's this one >> different? > > Because I copied it from the dri2 path not the pbuffer path. This idiom > is more correct, _XSetLastRequestRead is how you notify xlib

Re: [Mesa-dev] [PATCH] glx: Fix __glXWireToEvent for BufferSwapComplete

2015-08-05 Thread Adam Jackson
On Tue, 2015-08-04 at 19:38 -0700, Eric Anholt wrote: > In the Pbuffer path, we get serial from awire. Why's this one > different? Because I copied it from the dri2 path not the pbuffer path. This idiom is more correct, _XSetLastRequestRead is how you notify xlib of the advance in serials so it

Re: [Mesa-dev] [PATCH] glx: Fix __glXWireToEvent for BufferSwapComplete

2015-08-04 Thread Eric Anholt
Adam Jackson writes: > In the DRI2 path this event is magically synthesized from the > corresponding DRI2 event, but with Present, the server sends us the > event itself. The DRI2 path fills in the serial number, send_event, and > display fields of the XEvent struct that the app sees, but the Pre

[Mesa-dev] [PATCH] glx: Fix __glXWireToEvent for BufferSwapComplete

2015-07-31 Thread Adam Jackson
In the DRI2 path this event is magically synthesized from the corresponding DRI2 event, but with Present, the server sends us the event itself. The DRI2 path fills in the serial number, send_event, and display fields of the XEvent struct that the app sees, but the Present path did not. This is lik