Re: [Mesa-dev] [PATCH] glx: Don't uselessly dlopen libGL within libGL

2014-05-30 Thread Adam Jackson
On Thu, 2014-05-29 at 15:10 -0700, Ian Romanick wrote: > That code was originally added by: > > commit 061a3fe34051327fba418cc99599ecff0016ee15 > Author: Michel Dänzer > Date: Mon Aug 14 15:53:37 2006 + > > Bug #7169: Attempt to make libGL symbols visible to drivers. > > Some

Re: [Mesa-dev] [PATCH] glx: Don't uselessly dlopen libGL within libGL

2014-05-29 Thread Ian Romanick
On 05/29/2014 10:47 AM, Adam Jackson wrote: > This is entirely pointless. The DRI driver does not need any symbols > from libGL, even if it did libGL would already be available to resolve > them because that's how dlopen works. That code was originally added by: commit 061a3fe34051327fba418cc995

Re: [Mesa-dev] [PATCH] glx: Don't uselessly dlopen libGL within libGL

2014-05-29 Thread Emil Velikov
On 29/05/14 18:47, Adam Jackson wrote: > This is entirely pointless. The DRI driver does not need any symbols > from libGL, even if it did libGL would already be available to resolve > them because that's how dlopen works. > FWIW Reviewed-by: Emil Velikov -Emil > Signed-off-by: Adam Jackson >

Re: [Mesa-dev] [PATCH] glx: Don't uselessly dlopen libGL within libGL

2014-05-29 Thread Jose Fonseca
- Original Message - > This is entirely pointless. The DRI driver does not need any symbols > from libGL, even if it did I think DRI drivers did at one point depend on getting some glapi symbols from libGL.so. I don't recall which situations the DRI driver could be loaded without libG

[Mesa-dev] [PATCH] glx: Don't uselessly dlopen libGL within libGL

2014-05-29 Thread Adam Jackson
This is entirely pointless. The DRI driver does not need any symbols from libGL, even if it did libGL would already be available to resolve them because that's how dlopen works. Signed-off-by: Adam Jackson --- src/glx/dri_common.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) di