Re: [Mesa-dev] [PATCH] glsl_to_tgsi: Invalidate and revalidate uniform backing storage

2011-11-16 Thread Bryan Cain
It's unfortunately been a while since I've done anything with glsl_to_tgsi. What are the "various functions that modify the TGSI IR and try to propagate changes about that up to the gl_program"? If I can see where it is in the code, I can probably remember if there's a reason it was done that way

Re: [Mesa-dev] [PATCH] glsl_to_tgsi: Invalidate and revalidate uniform backing storage

2011-11-16 Thread Ian Romanick
On 11/16/2011 12:38 PM, Vadim Girlin wrote: This patch fixes memory corruption, thanks. Also there is another regression with Ligthsmark - incorrect rendering. I've bisected it and came to the same commit again. Most noticeable difference is in the very last scene - it should fade away, but it d

Re: [Mesa-dev] [PATCH] glsl_to_tgsi: Invalidate and revalidate uniform backing storage

2011-11-16 Thread Vadim Girlin
This patch fixes memory corruption, thanks. Also there is another regression with Ligthsmark - incorrect rendering. I've bisected it and came to the same commit again. Most noticeable difference is in the very last scene - it should fade away, but it doesn't. I can make the screenshots of good and

[Mesa-dev] [PATCH] glsl_to_tgsi: Invalidate and revalidate uniform backing storage

2011-11-16 Thread Ian Romanick
From: Ian Romanick If glUniform1i and friends are going to dump data directly in driver-allocated, the pointers have to be updated when the storage moves. This should fix the regressions seen with commit 7199096. I'm not sure if this is the only place that needs this treatment. I'm a little un