Re: [Mesa-dev] [PATCH] glsl: use set rather than old hash table for ir_validate

2015-07-10 Thread Iago Toral
On Fri, 2015-07-10 at 19:07 +1200, Chris Forbes wrote: > Perf data? When the new hash table implementation was added to Mesa by Eric it claimed to be much faster, see commits 35fd61bd99c1 and 72e55bb6888ff. The set implementation seems to follow the same implementation strategy, so I suppose it m

Re: [Mesa-dev] [PATCH] glsl: use set rather than old hash table for ir_validate

2015-07-10 Thread Timothy Arceri
On Fri, 2015-07-10 at 19:07 +1200, Chris Forbes wrote: > Perf data? I can create some if you like, but wasn't program/hash_table.c meant to die along time ago [1] anyway. [1] http://lists.freedesktop.org/archives/mesa-dev/2013-December/050524.html > > On Fri, Jul 10, 2015 at 6:41 PM, Timothy Ar

Re: [Mesa-dev] [PATCH] glsl: use set rather than old hash table for ir_validate

2015-07-10 Thread Chris Forbes
Perf data? On Fri, Jul 10, 2015 at 6:41 PM, Timothy Arceri wrote: > This implementation should be faster and there was no > need to store a data field. > --- > src/glsl/ir_validate.cpp | 24 > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/src/glsl/ir

[Mesa-dev] [PATCH] glsl: use set rather than old hash table for ir_validate

2015-07-09 Thread Timothy Arceri
This implementation should be faster and there was no need to store a data field. --- src/glsl/ir_validate.cpp | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/glsl/ir_validate.cpp b/src/glsl/ir_validate.cpp index cfe0df3..684bef2 100644 --- a/src/