Re: [Mesa-dev] [PATCH] glsl: use enum glsl_interface_packing in more places. (v2)

2016-06-05 Thread Ilia Mirkin
With the const's gone on the return types of the new helpers, this is Reviewed-by: Ilia Mirkin On Mon, Jun 6, 2016 at 12:21 AM, Dave Airlie wrote: > From: Dave Airlie > > Although the glsl_types.h stores this in a bitfield, > we should hide that from everyone else. Hide the cast > in an access

[Mesa-dev] [PATCH] glsl: use enum glsl_interface_packing in more places. (v2)

2016-06-05 Thread Dave Airlie
From: Dave Airlie Although the glsl_types.h stores this in a bitfield, we should hide that from everyone else. Hide the cast in an accessor method and use the enum everywhere. This makes things a bit nicer in gdb, and improves type safety. v2: fix a few pieces of interface I missed that caused

Re: [Mesa-dev] [PATCH] glsl: use enum glsl_interface_packing in more places.

2016-05-16 Thread Timothy Arceri
On Wed, 2016-05-11 at 10:50 +1000, Dave Airlie wrote: > From: Dave Airlie > > Although the glsl_types.h stores this in a bitfield, > we should hide that from everyone else. Hide the cast > in an accessor method and use the enum everywhere. > > This makes things a bit nicer in gdb, and improves t

[Mesa-dev] [PATCH] glsl: use enum glsl_interface_packing in more places.

2016-05-10 Thread Dave Airlie
From: Dave Airlie Although the glsl_types.h stores this in a bitfield, we should hide that from everyone else. Hide the cast in an accessor method and use the enum everywhere. This makes things a bit nicer in gdb, and improves type safety. Signed-off-by: Dave Airlie --- src/compiler/glsl/ir.h