Re: [Mesa-dev] [PATCH] glsl: set vector_elements to 1 for samplers

2017-04-29 Thread Samuel Pitoiset
On 04/28/2017 08:40 PM, Mark Janes wrote: Samuel Pitoiset writes: On 04/28/2017 06:58 PM, Mark Janes wrote: With this commit, a wide range of intel hardware began hanging during the GLES CTS, with dmesg errors like: [25488.739167] traps: glcts[15106] general protection ip:7fdac6484ba5 sp:

Re: [Mesa-dev] [PATCH] glsl: set vector_elements to 1 for samplers

2017-04-28 Thread Mark Janes
Samuel Pitoiset writes: > On 04/28/2017 06:58 PM, Mark Janes wrote: >> With this commit, a wide range of intel hardware began hanging during >> the GLES CTS, with dmesg errors like: >> >> [25488.739167] traps: glcts[15106] general protection ip:7fdac6484ba5 >> sp:7ffdcda85a20 error:0 >> >> Mac

Re: [Mesa-dev] [PATCH] glsl: set vector_elements to 1 for samplers

2017-04-28 Thread Samuel Pitoiset
On 04/28/2017 06:58 PM, Mark Janes wrote: With this commit, a wide range of intel hardware began hanging during the GLES CTS, with dmesg errors like: [25488.739167] traps: glcts[15106] general protection ip:7fdac6484ba5 sp:7ffdcda85a20 error:0 Machines that did complete the cts, reported hun

Re: [Mesa-dev] [PATCH] glsl: set vector_elements to 1 for samplers

2017-04-28 Thread Mark Janes
With this commit, a wide range of intel hardware began hanging during the GLES CTS, with dmesg errors like: [25488.739167] traps: glcts[15106] general protection ip:7fdac6484ba5 sp:7ffdcda85a20 error:0 Machines that did complete the cts, reported hundreds of errors like: *** Error in `/tmp/buil

Re: [Mesa-dev] [PATCH] glsl: set vector_elements to 1 for samplers

2017-04-27 Thread Nicolai Hähnle
On 26.04.2017 13:49, Samuel Pitoiset wrote: I don't see any reasons why vector_elements is 1 for images and 0 for samplers. This increases consistency and allows to clean up some code a bit. This will also help for ARB_bindless_texture. No piglit regressions with RadeonSI. Signed-off-by: Samue

Re: [Mesa-dev] [PATCH] glsl: set vector_elements to 1 for samplers

2017-04-26 Thread Timothy Arceri
Looks good to me. Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] glsl: set vector_elements to 1 for samplers

2017-04-26 Thread Samuel Pitoiset
I don't see any reasons why vector_elements is 1 for images and 0 for samplers. This increases consistency and allows to clean up some code a bit. This will also help for ARB_bindless_texture. No piglit regressions with RadeonSI. Signed-off-by: Samuel Pitoiset --- src/compiler/glsl_types.cpp