Re: [Mesa-dev] [PATCH] glsl: set the binding value regardless explicit_binding

2015-05-14 Thread Alejandro Piñeiro
On 14/05/15 20:38, Ian Romanick wrote: > On 05/14/2015 04:30 AM, Timothy Arceri wrote: >> On Wed, 2015-05-13 at 09:58 -0700, Ian Romanick wrote: >>> On 05/11/2015 03:37 AM, Alejandro Piñeiro wrote: Since commit c0cd5b var->data.binding was set only when explicit_binding was false, thas wa

Re: [Mesa-dev] [PATCH] glsl: set the binding value regardless explicit_binding

2015-05-14 Thread Ian Romanick
On 05/14/2015 04:30 AM, Timothy Arceri wrote: > On Wed, 2015-05-13 at 09:58 -0700, Ian Romanick wrote: >> On 05/11/2015 03:37 AM, Alejandro Piñeiro wrote: >>> Since commit c0cd5b var->data.binding was set only when explicit_binding >>> was false, thas was wrong, should be a test to true. This preve

Re: [Mesa-dev] [PATCH] glsl: set the binding value regardless explicit_binding

2015-05-14 Thread Alejandro Piñeiro
On 14/05/15 13:40, Timothy Arceri wrote: > On Wed, 2015-05-13 at 09:58 -0700, Ian Romanick wrote: >> On 05/11/2015 03:37 AM, Alejandro Piñeiro wrote: >>> Since commit c0cd5b var->data.binding was set only when explicit_binding >>> was false, thas was wrong, should be a test to true. This prevente

Re: [Mesa-dev] [PATCH] glsl: set the binding value regardless explicit_binding

2015-05-14 Thread Timothy Arceri
On Wed, 2015-05-13 at 09:58 -0700, Ian Romanick wrote: > On 05/11/2015 03:37 AM, Alejandro Piñeiro wrote: > > Since commit c0cd5b var->data.binding was set only when explicit_binding > > was false, thas was wrong, should be a test to true. This prevented > > to use any binding point different to 0.

Re: [Mesa-dev] [PATCH] glsl: set the binding value regardless explicit_binding

2015-05-14 Thread Timothy Arceri
On Wed, 2015-05-13 at 09:58 -0700, Ian Romanick wrote: > On 05/11/2015 03:37 AM, Alejandro Piñeiro wrote: > > Since commit c0cd5b var->data.binding was set only when explicit_binding > > was false, thas was wrong, should be a test to true. This prevented > > to use any binding point different to 0.

Re: [Mesa-dev] [PATCH] glsl: set the binding value regardless explicit_binding

2015-05-13 Thread Ian Romanick
On 05/11/2015 03:37 AM, Alejandro Piñeiro wrote: > Since commit c0cd5b var->data.binding was set only when explicit_binding > was false, thas was wrong, should be a test to true. This prevented > to use any binding point different to 0. > > In any case, that if statement is not needed. Right now m

Re: [Mesa-dev] [PATCH] glsl: set the binding value regardless explicit_binding

2015-05-12 Thread Timothy Arceri
On Mon, 2015-05-11 at 12:37 +0200, Alejandro Piñeiro wrote: > Since commit c0cd5b var->data.binding was set only when explicit_binding > was false, thas was wrong, should be a test to true. This prevented > to use any binding point different to 0. > > In any case, that if statement is not needed.

[Mesa-dev] [PATCH] glsl: set the binding value regardless explicit_binding

2015-05-11 Thread Alejandro Piñeiro
Since commit c0cd5b var->data.binding was set only when explicit_binding was false, thas was wrong, should be a test to true. This prevented to use any binding point different to 0. In any case, that if statement is not needed. Right now mesa requires all atomic counters to have an explicit bindin