Re: [Mesa-dev] [PATCH] glsl: replace null check with assert

2016-01-07 Thread Matt Turner
Have a Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] glsl: replace null check with assert

2016-01-06 Thread Timothy Arceri
Ping. Just looking over some older patches of mine. I made this change both as a clean up but also because the constant expression evaluation code is some of the most expensive in the compiler and this was right in the hot path for some of the AoA tests until I improved some other optimisation to

[Mesa-dev] [PATCH] glsl: replace null check with assert

2015-07-14 Thread Timothy Arceri
This was added in 54f583a20 since then error handling has improved. The test this was added to fix now fails earlier since 01822706ec --- src/glsl/ir_constant_expression.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/glsl/ir_constant_expression.cpp b/src/glsl/ir_c