Re: [Mesa-dev] [PATCH] glsl: remove redundant function inout assignments

2015-11-06 Thread Timothy Arceri
On Tue, 2015-11-03 at 20:42 -0500, Ilia Mirkin wrote: > On Tue, Nov 3, 2015 at 8:23 PM, Timothy Arceri > wrote: > > On Wed, 2015-11-04 at 12:12 +1100, Timothy Arceri wrote: > > > On Tue, 2015-11-03 at 19:39 -0500, Ilia Mirkin wrote: > > > > On Tue, Nov 3, 2015 at 7:31 PM, Timothy Arceri > > > > w

Re: [Mesa-dev] [PATCH] glsl: remove redundant function inout assignments

2015-11-03 Thread Timothy Arceri
On Tue, 2015-11-03 at 20:42 -0500, Ilia Mirkin wrote: > On Tue, Nov 3, 2015 at 8:23 PM, Timothy Arceri > wrote: > > On Wed, 2015-11-04 at 12:12 +1100, Timothy Arceri wrote: > > > On Tue, 2015-11-03 at 19:39 -0500, Ilia Mirkin wrote: > > > > On Tue, Nov 3, 2015 at 7:31 PM, Timothy Arceri > > > > w

Re: [Mesa-dev] [PATCH] glsl: remove redundant function inout assignments

2015-11-03 Thread Ilia Mirkin
On Tue, Nov 3, 2015 at 8:23 PM, Timothy Arceri wrote: > On Wed, 2015-11-04 at 12:12 +1100, Timothy Arceri wrote: >> On Tue, 2015-11-03 at 19:39 -0500, Ilia Mirkin wrote: >> > On Tue, Nov 3, 2015 at 7:31 PM, Timothy Arceri >> > wrote: >> > > On Tue, 2015-11-03 at 19:21 -0500, Ilia Mirkin wrote: >>

Re: [Mesa-dev] [PATCH] glsl: remove redundant function inout assignments

2015-11-03 Thread Timothy Arceri
On Wed, 2015-11-04 at 12:12 +1100, Timothy Arceri wrote: > On Tue, 2015-11-03 at 19:39 -0500, Ilia Mirkin wrote: > > On Tue, Nov 3, 2015 at 7:31 PM, Timothy Arceri > > wrote: > > > On Tue, 2015-11-03 at 19:21 -0500, Ilia Mirkin wrote: > > > > I'm still unclear what problem you're trying to solve h

Re: [Mesa-dev] [PATCH] glsl: remove redundant function inout assignments

2015-11-03 Thread Timothy Arceri
On Tue, 2015-11-03 at 19:39 -0500, Ilia Mirkin wrote: > On Tue, Nov 3, 2015 at 7:31 PM, Timothy Arceri > wrote: > > On Tue, 2015-11-03 at 19:21 -0500, Ilia Mirkin wrote: > > > I'm still unclear what problem you're trying to solve here? What's > > > wrong with having b[1] = b[1]? > > > > There is

Re: [Mesa-dev] [PATCH] glsl: remove redundant function inout assignments

2015-11-03 Thread Ilia Mirkin
On Tue, Nov 3, 2015 at 7:31 PM, Timothy Arceri wrote: > On Tue, 2015-11-03 at 19:21 -0500, Ilia Mirkin wrote: >> I'm still unclear what problem you're trying to solve here? What's >> wrong with having b[1] = b[1]? > > There is nothing wrong with it, but nir seems to expect this type of > assignmen

Re: [Mesa-dev] [PATCH] glsl: remove redundant function inout assignments

2015-11-03 Thread Timothy Arceri
On Tue, 2015-11-03 at 19:21 -0500, Ilia Mirkin wrote: > I'm still unclear what problem you're trying to solve here? What's > wrong with having b[1] = b[1]? There is nothing wrong with it, but nir seems to expect this type of assignment to be optimised out and hits an assert if its not. Its removed

Re: [Mesa-dev] [PATCH] glsl: remove redundant function inout assignments

2015-11-03 Thread Ilia Mirkin
I'm still unclear what problem you're trying to solve here? What's wrong with having b[1] = b[1]? On Tue, Nov 3, 2015 at 7:19 PM, Timothy Arceri wrote: > On Mon, 2015-11-02 at 03:27 -0500, Ilia Mirkin wrote: >> On Sun, Nov 1, 2015 at 3:33 AM, Timothy Arceri >> wrote: >> > Handles the case with f

Re: [Mesa-dev] [PATCH] glsl: remove redundant function inout assignments

2015-11-03 Thread Timothy Arceri
On Mon, 2015-11-02 at 03:27 -0500, Ilia Mirkin wrote: > On Sun, Nov 1, 2015 at 3:33 AM, Timothy Arceri > wrote: > > Handles the case with function inout params where array elements > > do an assignment to themselves e.g. > > > > void array_mod(inout int b[2]) > > { > > b[0] = int(2); > >

Re: [Mesa-dev] [PATCH] glsl: remove redundant function inout assignments

2015-11-02 Thread Ilia Mirkin
On Sun, Nov 1, 2015 at 3:33 AM, Timothy Arceri wrote: > Handles the case with function inout params where array elements > do an assignment to themselves e.g. > > void array_mod(inout int b[2]) > { > b[0] = int(2); > b[1] = b[1]; > } > > Fixes assert in nir for: > ES31-CTS.arrays_of_a

Re: [Mesa-dev] [PATCH] glsl: remove redundant function inout assignments

2015-11-02 Thread Lofstedt, Marta
Reviewed-by: Marta Lofstedt > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Timothy Arceri > Sent: Sunday, November 1, 2015 9:33 AM > To: mesa-dev@lists.freedesktop.org > Subject: [Mesa-dev] [PATCH] glsl: remove

[Mesa-dev] [PATCH] glsl: remove redundant function inout assignments

2015-11-01 Thread Timothy Arceri
Handles the case with function inout params where array elements do an assignment to themselves e.g. void array_mod(inout int b[2]) { b[0] = int(2); b[1] = b[1]; } Fixes assert in nir for: ES31-CTS.arrays_of_arrays.InteractionFunctionCalls2 https://bugs.freedesktop.org/show_bug.cgi?