Re: [Mesa-dev] [PATCH] glsl: remove excess location qualifier validation

2015-10-22 Thread Timothy Arceri
On Fri, 2015-10-23 at 08:01 +0300, Tapani Pälli wrote: > On 10/22/2015 11:07 AM, Timothy Arceri wrote: > > On Thu, 2015-10-22 at 09:56 +0300, Tapani Pälli wrote: > > > On 10/22/2015 09:41 AM, Timothy Arceri wrote: > > > > On Thu, 2015-10-22 at 08:55 +0300, Tapani Pälli wrote: > > > > > On 10/22/201

Re: [Mesa-dev] [PATCH] glsl: remove excess location qualifier validation

2015-10-22 Thread Tapani Pälli
On 10/22/2015 11:07 AM, Timothy Arceri wrote: On Thu, 2015-10-22 at 09:56 +0300, Tapani Pälli wrote: On 10/22/2015 09:41 AM, Timothy Arceri wrote: On Thu, 2015-10-22 at 08:55 +0300, Tapani Pälli wrote: On 10/22/2015 08:29 AM, Timothy Arceri wrote: Location has never been able to be a negative

Re: [Mesa-dev] [PATCH] glsl: remove excess location qualifier validation

2015-10-22 Thread Timothy Arceri
On Thu, 2015-10-22 at 09:56 +0300, Tapani Pälli wrote: > On 10/22/2015 09:41 AM, Timothy Arceri wrote: > > On Thu, 2015-10-22 at 08:55 +0300, Tapani Pälli wrote: > > > On 10/22/2015 08:29 AM, Timothy Arceri wrote: > > > > Location has never been able to be a negative value because it > > > > has >

Re: [Mesa-dev] [PATCH] glsl: remove excess location qualifier validation

2015-10-21 Thread Tapani Pälli
On 10/22/2015 09:41 AM, Timothy Arceri wrote: On Thu, 2015-10-22 at 08:55 +0300, Tapani Pälli wrote: On 10/22/2015 08:29 AM, Timothy Arceri wrote: Location has never been able to be a negative value because it has always been validated in the parser. Also the linker doesn't check for negatives

Re: [Mesa-dev] [PATCH] glsl: remove excess location qualifier validation

2015-10-21 Thread Timothy Arceri
On Thu, 2015-10-22 at 08:55 +0300, Tapani Pälli wrote: > On 10/22/2015 08:29 AM, Timothy Arceri wrote: > > Location has never been able to be a negative value because it has > > always been validated in the parser. > > > > Also the linker doesn't check for negatives like the comment > > claims. >

Re: [Mesa-dev] [PATCH] glsl: remove excess location qualifier validation

2015-10-21 Thread Tapani Pälli
On 10/22/2015 08:29 AM, Timothy Arceri wrote: Location has never been able to be a negative value because it has always been validated in the parser. Also the linker doesn't check for negatives like the comment claims. Neither does the parser, if one utilizes negative explicit location, parse

[Mesa-dev] [PATCH] glsl: remove excess location qualifier validation

2015-10-21 Thread Timothy Arceri
Location has never been able to be a negative value because it has always been validated in the parser. Also the linker doesn't check for negatives like the comment claims. --- No piglit regressions and an extra negative test sent for ARB_explicit_uniform_location [1] [1] http://patchwork.fre