Re: [Mesa-dev] [PATCH] glsl: reject explicit location on atomic counter uniforms

2016-02-15 Thread Timothy Arceri
On Mon, 2016-02-15 at 10:49 -0500, Nicolai Hähnle wrote: > > On 12.02.2016 17:53, Timothy Arceri wrote: > > On Thu, 2016-02-11 at 20:10 -0500, Ilia Mirkin wrote: > > > This fixes > > > > > > dEQP-GLES31.functional.uniform_location.negative.atomic_fragment > > > dEQP-GLES31.functional.uniform_loca

Re: [Mesa-dev] [PATCH] glsl: reject explicit location on atomic counter uniforms

2016-02-15 Thread Nicolai Hähnle
On 12.02.2016 17:53, Timothy Arceri wrote: On Thu, 2016-02-11 at 20:10 -0500, Ilia Mirkin wrote: This fixes dEQP-GLES31.functional.uniform_location.negative.atomic_fragment dEQP-GLES31.functional.uniform_location.negative.atomic_vertex Both of which have lines like layout(location = 3, bind

Re: [Mesa-dev] [PATCH] glsl: reject explicit location on atomic counter uniforms

2016-02-12 Thread Timothy Arceri
On Fri, 2016-02-12 at 20:57 -0500, Ilia Mirkin wrote: > On Fri, Feb 12, 2016 at 8:52 PM, Timothy Arceri u> wrote: > > On Fri, 2016-02-12 at 18:45 -0500, Ilia Mirkin wrote: > > > On Fri, Feb 12, 2016 at 5:53 PM, Timothy Arceri > > om.a > > > u> wrote: > > > > On Thu, 2016-02-11 at 20:10 -0500, Ili

Re: [Mesa-dev] [PATCH] glsl: reject explicit location on atomic counter uniforms

2016-02-12 Thread Ilia Mirkin
On Fri, Feb 12, 2016 at 8:52 PM, Timothy Arceri wrote: > On Fri, 2016-02-12 at 18:45 -0500, Ilia Mirkin wrote: >> On Fri, Feb 12, 2016 at 5:53 PM, Timothy Arceri > u> wrote: >> > On Thu, 2016-02-11 at 20:10 -0500, Ilia Mirkin wrote: >> > > This fixes >> > > >> > > dEQP-GLES31.functional.uniform_lo

Re: [Mesa-dev] [PATCH] glsl: reject explicit location on atomic counter uniforms

2016-02-12 Thread Timothy Arceri
On Fri, 2016-02-12 at 18:45 -0500, Ilia Mirkin wrote: > On Fri, Feb 12, 2016 at 5:53 PM, Timothy Arceri u> wrote: > > On Thu, 2016-02-11 at 20:10 -0500, Ilia Mirkin wrote: > > > This fixes > > > > > > dEQP-GLES31.functional.uniform_location.negative.atomic_fragment > > > dEQP-GLES31.functional.un

Re: [Mesa-dev] [PATCH] glsl: reject explicit location on atomic counter uniforms

2016-02-12 Thread Ilia Mirkin
On Fri, Feb 12, 2016 at 5:53 PM, Timothy Arceri wrote: > On Thu, 2016-02-11 at 20:10 -0500, Ilia Mirkin wrote: >> This fixes >> >> dEQP-GLES31.functional.uniform_location.negative.atomic_fragment >> dEQP-GLES31.functional.uniform_location.negative.atomic_vertex >> >> Both of which have lines like

Re: [Mesa-dev] [PATCH] glsl: reject explicit location on atomic counter uniforms

2016-02-12 Thread Timothy Arceri
On Thu, 2016-02-11 at 20:10 -0500, Ilia Mirkin wrote: > This fixes > > dEQP-GLES31.functional.uniform_location.negative.atomic_fragment > dEQP-GLES31.functional.uniform_location.negative.atomic_vertex > > Both of which have lines like > > layout(location = 3, binding = 0, offset = 0) uniform ato

[Mesa-dev] [PATCH] glsl: reject explicit location on atomic counter uniforms

2016-02-11 Thread Ilia Mirkin
This fixes dEQP-GLES31.functional.uniform_location.negative.atomic_fragment dEQP-GLES31.functional.uniform_location.negative.atomic_vertex Both of which have lines like layout(location = 3, binding = 0, offset = 0) uniform atomic_uint uni0; The ARB_explicit_uniform_location spec makes a very ta