Reviewed-by: Timothy Arceri
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 03/02/2017 08:36 PM, Mark Janes wrote:
Samuel Pitoiset writes:
Well, I have just tested it with mesa git-ca7d2025a7 (just before
be8aa76afd - glsl: remove unecessary flags.q.subroutine_def) and it also
fails. While git-be8aa76afd introduces a compile-time error:
"Failed to compile vertex
Samuel Pitoiset writes:
> Well, I have just tested it with mesa git-ca7d2025a7 (just before
> be8aa76afd - glsl: remove unecessary flags.q.subroutine_def) and it also
> fails. While git-be8aa76afd introduces a compile-time error:
>
> "Failed to compile vertex shader
> /home/hakzsam/programming
Well, I have just tested it with mesa git-ca7d2025a7 (just before
be8aa76afd - glsl: remove unecessary flags.q.subroutine_def) and it also
fails. While git-be8aa76afd introduces a compile-time error:
"Failed to compile vertex shader
/home/hakzsam/programming/piglit/tests/spec/arb_shader_subrou
On 03/02/2017 07:56 PM, Ilia Mirkin wrote:
Perhaps you ran the gpu profile?
Nope, tests/all.gpu
On Thu, Mar 2, 2017 at 1:50 PM, Samuel Pitoiset
wrote:
I wonder why piglit didn't report me that failure because I ran it with -t
subroutine before sending the patch...
On 03/02/2017 06:56 P
Perhaps you ran the gpu profile?
On Thu, Mar 2, 2017 at 1:50 PM, Samuel Pitoiset
wrote:
> I wonder why piglit didn't report me that failure because I ran it with -t
> subroutine before sending the patch...
>
>
> On 03/02/2017 06:56 PM, Mark Janes wrote:
>>
>> This patch regresses:
>> piglit.spec.
I wonder why piglit didn't report me that failure because I ran it with
-t subroutine before sending the patch...
On 03/02/2017 06:56 PM, Mark Janes wrote:
This patch regresses:
piglit.spec.arb_shader_subroutine.linker.no-overloads_vert
The program in the test should fail to link, but does not
This patch regresses:
piglit.spec.arb_shader_subroutine.linker.no-overloads_vert
The program in the test should fail to link, but does not.
Samuel Pitoiset writes:
> Previously, when q.subroutine was set to 1, a new subroutine
> declaration was added to the AST, while 0 meant a subroutine
> d
Previously, when q.subroutine was set to 1, a new subroutine
declaration was added to the AST, while 0 meant a subroutine
definition has been detected by the parser.
Thus, setting the q.subroutine flag in both situations is
obviously wrong because a new type identifier is added instead
of trying t
