Re: [Mesa-dev] [PATCH] glsl: fix constructing a vector from a matrix

2015-06-08 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 05/26/2015 03:32 PM, Martin Peres wrote: Without this patch, the following constructs (not an extensive list) would crash mesa: - mat2 foo = mat2(1); vec4 bar = vec4(foo); - mat3 foo = mat3(1); vec4 bar = vec4(foo); - mat3 foo = mat3(1); ivec4 bar = ivec4(foo); Th

[Mesa-dev] [PATCH] glsl: fix constructing a vector from a matrix

2015-05-26 Thread Martin Peres
Without this patch, the following constructs (not an extensive list) would crash mesa: - mat2 foo = mat2(1); vec4 bar = vec4(foo); - mat3 foo = mat3(1); vec4 bar = vec4(foo); - mat3 foo = mat3(1); ivec4 bar = ivec4(foo); The first case is explicitely allowed by the GLSL spec, as seen on page 101