On Thu, 2016-11-03 at 12:23 -0700, Ian Romanick wrote:
> I'm also a little curious how we get to this point with locp being
> NULL.
> Some commentary about that should at least go in the commit message.
So here is the reason.
Mesa initializes parser->version as 0. When finalizes parsing the
sh
Please add bug tag:
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97420
On 10/26/2016 02:42 PM, Juan A. Suarez Romero wrote:
Ignore source file, line number and column in glcpp_error() and
glcpp_warning() if those are not available.
It fixes 4 piglit tests:
spec/glsl-1.10/compiler/
On 10/31/2016 07:06 PM, Timothy Arceri wrote:
> On Mon, 2016-10-31 at 16:51 +0100, Juan A. Suarez Romero wrote:
>> On Wed, 2016-10-26 at 13:42 +0200, Juan A. Suarez Romero wrote:
>>>
>>> Ignore source file, line number and column in glcpp_error() and
>>> glcpp_warning() if those are not available.
On Mon, 2016-10-31 at 16:51 +0100, Juan A. Suarez Romero wrote:
> On Wed, 2016-10-26 at 13:42 +0200, Juan A. Suarez Romero wrote:
> >
> > Ignore source file, line number and column in glcpp_error() and
> > glcpp_warning() if those are not available.
> >
> > It fixes 4 piglit tests:
> > spec/gls
On Wed, 2016-10-26 at 13:42 +0200, Juan A. Suarez Romero wrote:
> Ignore source file, line number and column in glcpp_error() and
> glcpp_warning() if those are not available.
>
> It fixes 4 piglit tests:
> spec/glsl-1.10/compiler/version-0.frag: crash pass
> spec/glsl-1.10/compiler/version-0.
Ignore source file, line number and column in glcpp_error() and
glcpp_warning() if those are not available.
It fixes 4 piglit tests:
spec/glsl-1.10/compiler/version-0.frag: crash pass
spec/glsl-1.10/compiler/version-0.vert: crash pass
spec/glsl-es-3.00/compiler/version-0.frag: crash pass
s
On Wed, 2016-10-26 at 19:32 +1100, Timothy Arceri wrote:
> Please use braces with if when there is on more than a single line in
> the then/else blocks.
>
OK.
> Also there seems to be tabs in here please remove them when adding
> new
> code :)
Hmm... all the code in this file is using tabs. But
On Wed, 2016-10-26 at 09:13 +0200, Juan A. Suarez Romero wrote:
> Ignore source file, line number and column in glcpp_error() and
> glcpp_warning() if those are not available.
>
> It fixes 4 piglit tests:
> spec/glsl-1.10/compiler/version-0.frag: crash pass
> spec/glsl-1.10/compiler/version-0.
Ignore source file, line number and column in glcpp_error() and
glcpp_warning() if those are not available.
It fixes 4 piglit tests:
spec/glsl-1.10/compiler/version-0.frag: crash pass
spec/glsl-1.10/compiler/version-0.vert: crash pass
spec/glsl-es-3.00/compiler/version-0.frag: crash pass
s
