Re: [Mesa-dev] [PATCH] glsl: Fix indent in dump code

2017-06-20 Thread Ian Romanick
Reviewed-by: Ian Romanick On 03/06/2017 07:27 AM, Elie Tournier wrote: > From: Elie Tournier > > Signed-off-by: Elie Tournier > --- > On an other thread [1], we discovered than the GLSL compiler have some > trouble to indent correctly the dump IR. > > I don't have git access, please push it

Re: [Mesa-dev] [PATCH] glsl: Fix indent in dump code

2017-03-20 Thread tournier.elie
On 8 March 2017 at 14:56, tournier.elie wrote: > Right. > But did we generate lots of files w/ this method? > I only files I know are udivmod64.h and builtin_int64.h that you > generated for ARB_gpu_shader_int64. And these files are not impacted. Ping. Is anyone know the files generated by the st

Re: [Mesa-dev] [PATCH] glsl: Fix indent in dump code

2017-03-08 Thread tournier.elie
Right. But did we generate lots of files w/ this method? I only files I know are udivmod64.h and builtin_int64.h that you generated for ARB_gpu_shader_int64. And these files are not impacted. On 7 March 2017 at 20:23, Ian Romanick wrote: > Since this will affect generated code that is tracked in

Re: [Mesa-dev] [PATCH] glsl: Fix indent in dump code

2017-03-07 Thread Ian Romanick
Since this will affect generated code that is tracked in GIT, a second patch should regenerate all those files. Otherwise the next patch that causes those files to be regenerated will include a bunch of spurious changes. This is one of the (very strong) arguments against this sort of architecture

[Mesa-dev] [PATCH] glsl: Fix indent in dump code

2017-03-06 Thread Elie Tournier
From: Elie Tournier Signed-off-by: Elie Tournier --- On an other thread [1], we discovered than the GLSL compiler have some trouble to indent correctly the dump IR. I don't have git access, please push it for me. [1] https://lists.freedesktop.org/archives/mesa-dev/2017-March/146518.html ---