Re: [Mesa-dev] [PATCH] glsl: Avoid calling get_array_element for scalar constants

2018-08-16 Thread Danylo Piliaiev
On 08/16/2018 07:47 AM, Tapani Pälli wrote: On 08/16/2018 02:21 AM, Andres Gomez wrote: Danylo, should we also include this in the stable queues ? Yep makes sense, it's simple and fixes a crasher. I agree. On Mon, 2018-08-13 at 18:57 +0300, Danylo Piliaiev wrote: Accessing scalar cons

Re: [Mesa-dev] [PATCH] glsl: Avoid calling get_array_element for scalar constants

2018-08-15 Thread Tapani Pälli
On 08/16/2018 02:21 AM, Andres Gomez wrote: Danylo, should we also include this in the stable queues ? Yep makes sense, it's simple and fixes a crasher. On Mon, 2018-08-13 at 18:57 +0300, Danylo Piliaiev wrote: Accessing scalar constant as an array in function call or initializer list tri

Re: [Mesa-dev] [PATCH] glsl: Avoid calling get_array_element for scalar constants

2018-08-15 Thread Andres Gomez
Danylo, should we also include this in the stable queues ? On Mon, 2018-08-13 at 18:57 +0300, Danylo Piliaiev wrote: > Accessing scalar constant as an array in function call or > initializer list triggered assert in get_array_element. > Examples: >func(0[0]); >vec2 t = { 0[0], 0 }; > > B

Re: [Mesa-dev] [PATCH] glsl: Avoid calling get_array_element for scalar constants

2018-08-14 Thread Tapani Pälli
On 08/14/2018 12:15 PM, Danylo Piliaiev wrote: Hi, On 08/14/2018 10:53 AM, Tapani Pälli wrote: Hi; On 08/13/2018 06:57 PM, Danylo Piliaiev wrote: Accessing scalar constant as an array in function call or initializer list triggered assert in get_array_element. Examples:     func(0[0]);    

Re: [Mesa-dev] [PATCH] glsl: Avoid calling get_array_element for scalar constants

2018-08-14 Thread Danylo Piliaiev
Hi, On 08/14/2018 10:43 AM, Tapani Pälli wrote: On 08/13/2018 08:54 PM, Ian Romanick wrote: On 08/13/2018 08:57 AM, Danylo Piliaiev wrote: Accessing scalar constant as an array in function call or initializer list triggered assert in get_array_element. Examples:     func(0[0]);     vec2 t =

Re: [Mesa-dev] [PATCH] glsl: Avoid calling get_array_element for scalar constants

2018-08-14 Thread Danylo Piliaiev
Hi, On 08/14/2018 10:53 AM, Tapani Pälli wrote: Hi; On 08/13/2018 06:57 PM, Danylo Piliaiev wrote: Accessing scalar constant as an array in function call or initializer list triggered assert in get_array_element. Examples:     func(0[0]);     vec2 t = { 0[0], 0 }; Bugzilla: https://bugs.free

Re: [Mesa-dev] [PATCH] glsl: Avoid calling get_array_element for scalar constants

2018-08-14 Thread Tapani Pälli
Hi; On 08/13/2018 06:57 PM, Danylo Piliaiev wrote: Accessing scalar constant as an array in function call or initializer list triggered assert in get_array_element. Examples: func(0[0]); vec2 t = { 0[0], 0 }; Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107550 Signed-off-by:

Re: [Mesa-dev] [PATCH] glsl: Avoid calling get_array_element for scalar constants

2018-08-14 Thread Tapani Pälli
On 08/13/2018 08:54 PM, Ian Romanick wrote: On 08/13/2018 08:57 AM, Danylo Piliaiev wrote: Accessing scalar constant as an array in function call or initializer list triggered assert in get_array_element. Examples: func(0[0]); vec2 t = { 0[0], 0 }; Do we have tests like this in pigli

Re: [Mesa-dev] [PATCH] glsl: Avoid calling get_array_element for scalar constants

2018-08-13 Thread Ian Romanick
On 08/13/2018 08:57 AM, Danylo Piliaiev wrote: > Accessing scalar constant as an array in function call or > initializer list triggered assert in get_array_element. > Examples: >func(0[0]); >vec2 t = { 0[0], 0 }; Do we have tests like this in piglit? What happens if 0[0] syntax is used ot

[Mesa-dev] [PATCH] glsl: Avoid calling get_array_element for scalar constants

2018-08-13 Thread Danylo Piliaiev
Accessing scalar constant as an array in function call or initializer list triggered assert in get_array_element. Examples: func(0[0]); vec2 t = { 0[0], 0 }; Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107550 Signed-off-by: Danylo Piliaiev --- src/compiler/glsl/ir_constant_expr