Re: [Mesa-dev] [PATCH] glsl/cse: Maintain a list of free ae_entry objects

2015-03-27 Thread Ian Romanick
On 03/27/2015 11:56 AM, Thomas Helland wrote: > This looks good to me, and matches a solution I found > online the other day for reducing memory allocation overhead. > > Reviewed-by: Thomas Helland > > Did you happen to profile this? Did you identify other places that > could need a similar trea

Re: [Mesa-dev] [PATCH] glsl/cse: Maintain a list of free ae_entry objects

2015-03-27 Thread Ian Romanick
On 03/27/2015 11:33 AM, Kenneth Graunke wrote: > On Thursday, March 26, 2015 08:52:33 PM Ian Romanick wrote: >> From: Ian Romanick >> >> The CSE algorithm will continuously allocate new ae_entry objects. As >> each new basic block is exited, all of the previously allocated objects >> are dumped.

Re: [Mesa-dev] [PATCH] glsl/cse: Maintain a list of free ae_entry objects

2015-03-27 Thread Eric Anholt
Kenneth Graunke writes: > On Thursday, March 26, 2015 08:52:33 PM Ian Romanick wrote: >> From: Ian Romanick >> >> The CSE algorithm will continuously allocate new ae_entry objects. As >> each new basic block is exited, all of the previously allocated objects >> are dumped. Instead, put them i

Re: [Mesa-dev] [PATCH] glsl/cse: Maintain a list of free ae_entry objects

2015-03-27 Thread Thomas Helland
This looks good to me, and matches a solution I found online the other day for reducing memory allocation overhead. Reviewed-by: Thomas Helland Did you happen to profile this? Did you identify other places that could need a similar treatment? I'm about to do a last round of micro-adjustments and

Re: [Mesa-dev] [PATCH] glsl/cse: Maintain a list of free ae_entry objects

2015-03-27 Thread Kenneth Graunke
On Thursday, March 26, 2015 08:52:33 PM Ian Romanick wrote: > From: Ian Romanick > > The CSE algorithm will continuously allocate new ae_entry objects. As > each new basic block is exited, all of the previously allocated objects > are dumped. Instead, put them in a free list and re-use them in

Re: [Mesa-dev] [PATCH] glsl/cse: Maintain a list of free ae_entry objects

2015-03-27 Thread Jordan Justen
On 2015-03-26 20:52:33, Ian Romanick wrote: > From: Ian Romanick > > The CSE algorithm will continuously allocate new ae_entry objects. As > each new basic block is exited, all of the previously allocated objects > are dumped. Instead, put them in a free list and re-use them in the > next basic

[Mesa-dev] [PATCH] glsl/cse: Maintain a list of free ae_entry objects

2015-03-26 Thread Ian Romanick
From: Ian Romanick The CSE algorithm will continuously allocate new ae_entry objects. As each new basic block is exited, all of the previously allocated objects are dumped. Instead, put them in a free list and re-use them in the next basic block. Reduce, reuse, recycle! Signed-off-by: Ian Rom