Re: [Mesa-dev] [PATCH] glsl/blob: clear padding bytes

2017-03-09 Thread Timothy Arceri
On 08/03/17 23:28, Grazvydas Ignotas wrote: (CCing some people who touched or reviewed blob) Ping. I think writing stale heap contents to cache should be avoided and this patch is an improvement. Gražvydas On Fri, Mar 3, 2017 at 1:59 AM, Grazvydas Ignotas wrote: Since blob is intended for ser

Re: [Mesa-dev] [PATCH] glsl/blob: clear padding bytes

2017-03-08 Thread Grazvydas Ignotas
(CCing some people who touched or reviewed blob) Ping. I think writing stale heap contents to cache should be avoided and this patch is an improvement. Gražvydas On Fri, Mar 3, 2017 at 1:59 AM, Grazvydas Ignotas wrote: > Since blob is intended for serializing data, it's not a good idea to > leav

[Mesa-dev] [PATCH] glsl/blob: clear padding bytes

2017-03-02 Thread Grazvydas Ignotas
Since blob is intended for serializing data, it's not a good idea to leave padding holes with uninitialized data, which may leak heap contents and hurt compression if the blob is later compressed, like done by shader cache. Clear it. Signed-off-by: Grazvydas Ignotas --- I don't know why blob both