Re: [Mesa-dev] [PATCH] glsl/ast: don't allow subroutine uniform comparisons

2016-07-21 Thread Ian Romanick
On 07/19/2016 01:45 PM, Ian Romanick wrote: > On 07/19/2016 06:54 AM, Andres Gomez wrote: >> Hi, >> >> Just dropped: >> https://lists.freedesktop.org/archives/mesa-dev/2016-July/123485.html >> >> I didn't realize there was already this thread open. >> >> On Tue, 2016-06-07 at 09:59 -0700, Ian Roman

Re: [Mesa-dev] [PATCH] glsl/ast: don't allow subroutine uniform comparisons

2016-07-19 Thread Andres Gomez
On Tue, 2016-07-19 at 13:45 -0700, Ian Romanick wrote: > On 07/19/2016 06:54 AM, Andres Gomez wrote: ... > > So, what would be the conclusion? Do we allow subroutine variables > > comparison? > > There is no conclusion yet. I opened a Khronos gitlab tracker (right > after Dave sent his original

Re: [Mesa-dev] [PATCH] glsl/ast: don't allow subroutine uniform comparisons

2016-07-19 Thread Ian Romanick
On 07/19/2016 06:54 AM, Andres Gomez wrote: > Hi, > > Just dropped: > https://lists.freedesktop.org/archives/mesa-dev/2016-July/123485.html > > I didn't realize there was already this thread open. > > On Tue, 2016-06-07 at 09:59 -0700, Ian Romanick wrote: >> On 06/06/2016 10:20 PM, Dave Airlie w

Re: [Mesa-dev] [PATCH] glsl/ast: don't allow subroutine uniform comparisons

2016-07-19 Thread Andres Gomez
On Tue, 2016-06-07 at 15:20 +1000, Dave Airlie wrote: > From: Dave Airlie > > This fixes: > GL45-CTS.shader_subroutine.subroutines_cannot_be_assigned_float_int_values_or_be_compared > > though I'm not 100% sure why this is illegal from the spec, > but it makes us pass the test, and I really can'

Re: [Mesa-dev] [PATCH] glsl/ast: don't allow subroutine uniform comparisons

2016-07-19 Thread Andres Gomez
Hi, Just dropped: https://lists.freedesktop.org/archives/mesa-dev/2016-July/123485.html I didn't realize there was already this thread open. On Tue, 2016-06-07 at 09:59 -0700, Ian Romanick wrote: > On 06/06/2016 10:20 PM, Dave Airlie wrote: > > From: Dave Airlie > > > > This fixes: > > GL45-CT

Re: [Mesa-dev] [PATCH] glsl/ast: don't allow subroutine uniform comparisons

2016-06-07 Thread Ian Romanick
On 06/06/2016 10:20 PM, Dave Airlie wrote: > From: Dave Airlie > > This fixes: > GL45-CTS.shader_subroutine.subroutines_cannot_be_assigned_float_int_values_or_be_compared > > though I'm not 100% sure why this is illegal from the spec, > but it makes us pass the test, and I really can't see a use

Re: [Mesa-dev] [PATCH] glsl/ast: don't allow subroutine uniform comparisons

2016-06-07 Thread Alejandro Piñeiro
On 07/06/16 07:20, Dave Airlie wrote: > From: Dave Airlie > > This fixes: > GL45-CTS.shader_subroutine.subroutines_cannot_be_assigned_float_int_values_or_be_compared > > though I'm not 100% sure why this is illegal from the spec, Reading a little the spec, I also didn't find any explicit referen

[Mesa-dev] [PATCH] glsl/ast: don't allow subroutine uniform comparisons

2016-06-06 Thread Dave Airlie
From: Dave Airlie This fixes: GL45-CTS.shader_subroutine.subroutines_cannot_be_assigned_float_int_values_or_be_compared though I'm not 100% sure why this is illegal from the spec, but it makes us pass the test, and I really can't see a use case for this. Signged-off-by: Dave Airlie --- src/co