Re: [Mesa-dev] [PATCH] glcpp: Reject token pasting operator in GLES

2012-11-29 Thread Matt Turner
On Wed, Nov 28, 2012 at 2:12 PM, Ian Romanick wrote: > On 11/28/2012 11:21 AM, Matt Turner wrote: >> >> The GLSL ES 3.0 spec (Section 12.17) says: >> "GLSL ES 1.00 removed token pasting and other functionality." > > > Do we have piglit tests? 'make check' tests? No, I'll do so. > I assume this

Re: [Mesa-dev] [PATCH] glcpp: Reject token pasting operator in GLES

2012-11-28 Thread Carl Worth
Matt Turner writes: > "##" { > + if (parser->is_gles) > + glcpp_error(yylloc, yyextra, "Token pasting (##) is illegal in > GLES"); > return PASTE; I'm glad that is_gles flag is proving useful. Thanks for doing this one. Reviewed-by: Carl Worth -Carl -- carl.d.wo...@in

Re: [Mesa-dev] [PATCH] glcpp: Reject token pasting operator in GLES

2012-11-28 Thread Ian Romanick
On 11/28/2012 11:21 AM, Matt Turner wrote: The GLSL ES 3.0 spec (Section 12.17) says: "GLSL ES 1.00 removed token pasting and other functionality." Do we have piglit tests? 'make check' tests? I assume this passes the GLES3 conformance test without regressing anything. This should be marke

[Mesa-dev] [PATCH] glcpp: Reject token pasting operator in GLES

2012-11-28 Thread Matt Turner
The GLSL ES 3.0 spec (Section 12.17) says: "GLSL ES 1.00 removed token pasting and other functionality." --- src/glsl/glcpp/glcpp-lex.l |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/glsl/glcpp/glcpp-lex.l b/src/glsl/glcpp/glcpp-lex.l index fd28711..a029f62 100644 --