Re: [Mesa-dev] [PATCH] glcpp: Don't use infinite lookhead for #define differentiation.

2012-10-25 Thread Carl Worth
Kenneth Graunke writes: > Fixes piglit test 17000-consecutive-chars-identifier.frag. Thanks for fixing this. It will be nice to have this long-standing bug finally addressed. Reviewed-by: Carl Worth -Carl pgpO8dqDxs6Gd.pgp Description: PGP signature __

[Mesa-dev] [PATCH] glcpp: Don't use infinite lookhead for #define differentiation.

2012-10-22 Thread Kenneth Graunke
Previously, we used lookahead patterns to differentiate: #define FOO(x) function macro #define FOO (x) object macro Unfortunately, our rule for function macros: {HASH}define{HSPACE}+/{IDENTIFIER}"(" relies on infinite lookahead, and apparently triggers a Flex bug where the generated c