Re: [Mesa-dev] [PATCH] glcpp: Avoid unnecessary call to strlen

2017-09-26 Thread Thomas Helland
I've now pushed the series, so feel free to rebase =) 2017-09-22 16:10 GMT+02:00 Ian Romanick : > This patch is > > Reviewed-by: Ian Romanick > > I have a couple patches that go on top of this particular patch, and I'd > rather rebase before I send them out for review. :) > > On 09/14/2017 03:39

Re: [Mesa-dev] [PATCH] glcpp: Avoid unnecessary call to strlen

2017-09-22 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick I have a couple patches that go on top of this particular patch, and I'd rather rebase before I send them out for review. :) On 09/14/2017 03:39 PM, Thomas Helland wrote: > Length of the token was already calculated by flex and stored in yyleng, > no need

[Mesa-dev] [PATCH] glcpp: Avoid unnecessary call to strlen

2017-09-14 Thread Thomas Helland
Length of the token was already calculated by flex and stored in yyleng, no need to implicitly call strlen() via linear_strdup(). Reviewed-by: Nicolai Hähnle Reviewed-by: Timothy Arceri V2: Also convert this pattern in glsl_lexer.ll V3: Remove a misplaced comment V4: Use a temporary char to a

Re: [Mesa-dev] [PATCH] glcpp: Avoid unnecessary call to strlen

2017-08-30 Thread Thomas Helland
2017-08-31 2:20 GMT+02:00 Timothy Arceri : > > > On 31/08/17 06:19, Thomas Helland wrote: >> >> Length of the token was already calculated by flex and stored in yyleng, >> no need to implicitly call strlen() via linear_strdup(). >> >> V2: Also convert this pattern in glsl_lexer.ll >> This has

Re: [Mesa-dev] [PATCH] glcpp: Avoid unnecessary call to strlen

2017-08-30 Thread Timothy Arceri
On 31/08/17 06:19, Thomas Helland wrote: Length of the token was already calculated by flex and stored in yyleng, no need to implicitly call strlen() via linear_strdup(). V2: Also convert this pattern in glsl_lexer.ll This has a surprising result of reducing executed cyles from 1.06

[Mesa-dev] [PATCH] glcpp: Avoid unnecessary call to strlen

2017-08-30 Thread Thomas Helland
Length of the token was already calculated by flex and stored in yyleng, no need to implicitly call strlen() via linear_strdup(). V2: Also convert this pattern in glsl_lexer.ll This has a surprising result of reducing executed cyles from 1.06 trillion to 1.03 trillion, a significant change