Re: [Mesa-dev] [PATCH] gbm: make 'devices' array static

2014-03-08 Thread Emil Velikov
On 03/03/14 17:31, Julien Cristau wrote: > On Mon, Mar 3, 2014 at 17:29:56 +, Emil Velikov wrote: > >> On 03/03/14 17:23, Julien Cristau wrote: >>> On Mon, Mar 3, 2014 at 17:21:15 +, Emil Velikov wrote: >>> On 03/03/14 16:41, Julien Cristau wrote: > It's only used in this one fi

Re: [Mesa-dev] [PATCH] gbm: make 'devices' array static

2014-03-03 Thread Julien Cristau
On Mon, Mar 3, 2014 at 17:29:56 +, Emil Velikov wrote: > On 03/03/14 17:23, Julien Cristau wrote: > > On Mon, Mar 3, 2014 at 17:21:15 +, Emil Velikov wrote: > > > >> On 03/03/14 16:41, Julien Cristau wrote: > >>> It's only used in this one file as far as I can tell, and exporting a > >>

Re: [Mesa-dev] [PATCH] gbm: make 'devices' array static

2014-03-03 Thread Emil Velikov
On 03/03/14 16:41, Julien Cristau wrote: > It's only used in this one file as far as I can tell, and exporting a > symbol named 'devices' from a shared library is a recipe for trouble. Hmm did you really get the 'devices' exported symbol, or did you notice this while going through the code ? Either

Re: [Mesa-dev] [PATCH] gbm: make 'devices' array static

2014-03-03 Thread Emil Velikov
On 03/03/14 17:23, Julien Cristau wrote: > On Mon, Mar 3, 2014 at 17:21:15 +, Emil Velikov wrote: > >> On 03/03/14 16:41, Julien Cristau wrote: >>> It's only used in this one file as far as I can tell, and exporting a >>> symbol named 'devices' from a shared library is a recipe for trouble. >

Re: [Mesa-dev] [PATCH] gbm: make 'devices' array static

2014-03-03 Thread Julien Cristau
On Mon, Mar 3, 2014 at 17:21:15 +, Emil Velikov wrote: > On 03/03/14 16:41, Julien Cristau wrote: > > It's only used in this one file as far as I can tell, and exporting a > > symbol named 'devices' from a shared library is a recipe for trouble. > Hmm did you really get the 'devices' exported

[Mesa-dev] [PATCH] gbm: make 'devices' array static

2014-03-03 Thread Julien Cristau
It's only used in this one file as far as I can tell, and exporting a symbol named 'devices' from a shared library is a recipe for trouble. --- src/gbm/main/gbm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gbm/main/gbm.c b/src/gbm/main/gbm.c index b057386..30785a6 1006