Re: [Mesa-dev] [PATCH] gallivm: fix issue with AtomicCmpXchg wrapper on llvm 3.5-3.8

2019-08-02 Thread Charmaine Lee
The patch looks good to me. It replaces my earlier patch request on the same issue. Reviewed-by: Charmaine Lee On 8/2/19, 9:54 AM, "Brian Paul" wrote: On 08/02/2019 10:36 AM, srol...@vmware.com wrote: > From: Roland Scheidegger > > These versions still need wrapper but al

Re: [Mesa-dev] [PATCH] gallivm: fix issue with AtomicCmpXchg wrapper on llvm 3.5-3.8

2019-08-02 Thread Roland Scheidegger
Am 02.08.19 um 18:54 schrieb Brian Paul: > On 08/02/2019 10:36 AM, srol...@vmware.com wrote: >> From: Roland Scheidegger >> >> These versions still need wrapper but already have both success and >> failure ordering. >> (Compile tested on llvm 3.7, llvm 3.8.) >> >> Bugzilla: https://bugs.freedeskto

Re: [Mesa-dev] [PATCH] gallivm: fix issue with AtomicCmpXchg wrapper on llvm 3.5-3.8

2019-08-02 Thread Brian Paul
On 08/02/2019 10:36 AM, srol...@vmware.com wrote: From: Roland Scheidegger These versions still need wrapper but already have both success and failure ordering. (Compile tested on llvm 3.7, llvm 3.8.) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=02 --- src/gallium/auxiliary/gal

[Mesa-dev] [PATCH] gallivm: fix issue with AtomicCmpXchg wrapper on llvm 3.5-3.8

2019-08-02 Thread sroland
From: Roland Scheidegger These versions still need wrapper but already have both success and failure ordering. (Compile tested on llvm 3.7, llvm 3.8.) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=02 --- src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 16 +++- 1 file ch