Re: [Mesa-dev] [PATCH] gallivm: correctly manage MCJIT at run-time

2017-01-18 Thread Jose Fonseca
On 17/01/17 13:26, Emil Velikov wrote: > On 16 January 2017 at 14:44, Jose Fonseca wrote: >> On 16/01/17 13:46, Emil Velikov wrote: >>> >>> On 14 January 2017 at 08:46, Jose Fonseca wrote: I suspect this might break builds with LLVM 3.6 or higher. The LLVMLinkInJIT must be ins

Re: [Mesa-dev] [PATCH] gallivm: correctly manage MCJIT at run-time

2017-01-17 Thread Emil Velikov
On 16 January 2017 at 14:44, Jose Fonseca wrote: > On 16/01/17 13:46, Emil Velikov wrote: >> >> On 14 January 2017 at 08:46, Jose Fonseca wrote: >>> >>> I suspect this might break builds with LLVM 3.6 or higher. >>> >>> The LLVMLinkInJIT must be inside #if ... #endif, and it must not be >>> expan

Re: [Mesa-dev] [PATCH] gallivm: correctly manage MCJIT at run-time

2017-01-16 Thread Jose Fonseca
On 16/01/17 13:46, Emil Velikov wrote: On 14 January 2017 at 08:46, Jose Fonseca wrote: I suspect this might break builds with LLVM 3.6 or higher. The LLVMLinkInJIT must be inside #if ... #endif, and it must not be expanded when HAVE_LLVM >= 0x0306, since LLVMLinkInJIT(), That is, when HAVE_L

Re: [Mesa-dev] [PATCH] gallivm: correctly manage MCJIT at run-time

2017-01-16 Thread Emil Velikov
On 14 January 2017 at 08:46, Jose Fonseca wrote: > I suspect this might break builds with LLVM 3.6 or higher. > > The LLVMLinkInJIT must be inside #if ... #endif, and it must not be expanded > when HAVE_LLVM >= 0x0306, since LLVMLinkInJIT(), > > That is, when HAVE_LLVM >= 0x0306: > - USE_MCJIT sho

Re: [Mesa-dev] [PATCH] gallivm: correctly manage MCJIT at run-time

2017-01-14 Thread Jose Fonseca
I suspect this might break builds with LLVM 3.6 or higher. The LLVMLinkInJIT must be inside #if ... #endif, and it must not be expanded when HAVE_LLVM >= 0x0306, since LLVMLinkInJIT(), That is, when HAVE_LLVM >= 0x0306: - USE_MCJIT should be static const - no point claling GALLIVM_MCJIT - must

[Mesa-dev] [PATCH] gallivm: correctly manage MCJIT at run-time

2017-01-13 Thread Emil Velikov
Earlier commit made the decision whether to use MCJIT a run-time one. At the same time, it changed the code-flow in the following manner: - LLVMLinkInMCJIT() was executed regardless of whether MCJIT is to be used or not. Admittedly it is a no-op at least in some builds. - LLVMLinkInJIT() was exec