On Fri, Oct 6, 2017 at 1:24 AM, Roland Scheidegger wrote:
> Am 06.10.2017 um 00:34 schrieb Marek Olšák:
>> On Thu, Oct 5, 2017 at 8:00 PM, Ilia Mirkin wrote:
>>> On Thu, Oct 5, 2017 at 1:45 PM, Marek Olšák wrote:
On Thu, Oct 5, 2017 at 4:45 PM, Ilia Mirkin wrote:
> Like Roland, I don't
Am 06.10.2017 um 00:34 schrieb Marek Olšák:
> On Thu, Oct 5, 2017 at 8:00 PM, Ilia Mirkin wrote:
>> On Thu, Oct 5, 2017 at 1:45 PM, Marek Olšák wrote:
>>> On Thu, Oct 5, 2017 at 4:45 PM, Ilia Mirkin wrote:
Like Roland, I don't see what's being gained. It's more code
everywhere and hard
On Thu, Oct 5, 2017 at 8:00 PM, Ilia Mirkin wrote:
> On Thu, Oct 5, 2017 at 1:45 PM, Marek Olšák wrote:
>> On Thu, Oct 5, 2017 at 4:45 PM, Ilia Mirkin wrote:
>>> Like Roland, I don't see what's being gained. It's more code
>>> everywhere and harder to read the TGSI directly.
>>
>> Harder to read
On Thu, Oct 5, 2017 at 1:45 PM, Marek Olšák wrote:
> On Thu, Oct 5, 2017 at 4:45 PM, Ilia Mirkin wrote:
>> Like Roland, I don't see what's being gained. It's more code
>> everywhere and harder to read the TGSI directly.
>
> Harder to read the "IMM" string in the operand?
Yeah. You see a KILL_IF
On Thu, Oct 5, 2017 at 4:45 PM, Ilia Mirkin wrote:
> Like Roland, I don't see what's being gained. It's more code
> everywhere and harder to read the TGSI directly.
Harder to read the "IMM" string in the operand?
"more code everywhere"?
21 files changed, 22 insertions(+), 200 deletions(-)
This
Like Roland, I don't see what's being gained. It's more code
everywhere and harder to read the TGSI directly.
Neither nv30 nor nv50+ do the checks you suggest.
On Thu, Oct 5, 2017 at 9:00 AM, Marek Olšák wrote:
> I understand, but you can get KILL by checking if src0 is an immediate. You
> don't
I didn't like this when it was proposed a couple weeks ago, and
unsurprisingly I still don't like it now.
The reason is that KILL is a simple opcode which even maps to what both
glsl and d3d10 actually need, whereas KILL_IF is a complicated mess
including combined per-channel comparisons.
I realize
From: Marek Olšák
It can be recognized from KILL_IF by checking if the src operand is IMM.
---
src/gallium/auxiliary/gallivm/lp_bld_tgsi_action.c | 11 --
src/gallium/auxiliary/gallivm/lp_bld_tgsi_aos.c| 3 --
src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c| 42 -
