Re: [Mesa-dev] [PATCH] gallium: pass in per-sample interpolation qualifier

2014-07-03 Thread Roland Scheidegger
Am 03.07.2014 03:19, schrieb Ilia Mirkin: > On Wed, Jul 2, 2014 at 4:03 PM, Roland Scheidegger wrote: >> Actually on second thought, because centroid and sample are mutually >> exclusive (or more generally, the "Interpolate" member determines "how" >> interpolation is done, whereas these two deter

Re: [Mesa-dev] [PATCH] gallium: pass in per-sample interpolation qualifier

2014-07-02 Thread Ilia Mirkin
On Wed, Jul 2, 2014 at 4:03 PM, Roland Scheidegger wrote: > Actually on second thought, because centroid and sample are mutually > exclusive (or more generally, the "Interpolate" member determines "how" > interpolation is done, whereas these two determine the "where") > something like this might b

Re: [Mesa-dev] [PATCH] gallium: pass in per-sample interpolation qualifier

2014-07-02 Thread Roland Scheidegger
Actually on second thought, because centroid and sample are mutually exclusive (or more generally, the "Interpolate" member determines "how" interpolation is done, whereas these two determine the "where") something like this might be better: struct tgsi_declaration_interp { unsigned Interpolate

Re: [Mesa-dev] [PATCH] gallium: pass in per-sample interpolation qualifier

2014-07-02 Thread Roland Scheidegger
I don't have much of an idea how the interaction with per sample shading should look like, but this looks alright to me. Roland Am 02.07.2014 03:55, schrieb Ilia Mirkin: > Signed-off-by: Ilia Mirkin > --- > > Not sure if this is the right approach or if I should combine it with Centroid > more

[Mesa-dev] [PATCH] gallium: pass in per-sample interpolation qualifier

2014-07-01 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- Not sure if this is the right approach or if I should combine it with Centroid more directly. More modifications will be required wrt per-sample shading since we'll need to distinguish the min samples case where everything is per-sample-interpolated vs this case whe