Re: [Mesa-dev] [PATCH] gallium: add double opcodes and TGSI execution (v2.1)

2015-02-04 Thread Dave Airlie
On 30 December 2014 at 08:14, Roland Scheidegger wrote: > Just minor nits, looks good to me otherwise. > I agree with others that probably the round family of functions should > be added too (but could be done in another patch). Maybe could have one > cap bit then (so some implementations only doi

Re: [Mesa-dev] [PATCH] gallium: add double opcodes and TGSI execution (v2.1)

2014-12-29 Thread Roland Scheidegger
Just minor nits, looks good to me otherwise. I agree with others that probably the round family of functions should be added too (but could be done in another patch). Maybe could have one cap bit then (so some implementations only doing what's required by sm5, hence missing things like round and rs

Re: [Mesa-dev] [PATCH] gallium: add double opcodes and TGSI execution (v2.1)

2014-12-23 Thread Ilia Mirkin
On Tue, Dec 23, 2014 at 10:42 PM, Dave Airlie wrote: >>> +#define TGSI_OPCODE_DRCP208 /* eg, cayman */ >>> +#define TGSI_OPCODE_DSQRT 209 /* eg, cayman also has DRSQ >>> */ >> >> >> Adding DRSQ seems like a good idea, at least for graphics with floats its >> more freq

Re: [Mesa-dev] [PATCH] gallium: add double opcodes and TGSI execution (v2.1)

2014-12-23 Thread Dave Airlie
>> + // fprintf(stderr, "%f %f\n", src[0].d[0], src[1].d[0]); > > > leftover debug print dropped, >> enum tgsi_exec_datatype { >> TGSI_EXEC_DATA_FLOAT, >> TGSI_EXEC_DATA_INT, >> - TGSI_EXEC_DATA_UINT >> + TGSI_EXEC_DATA_UINT, >> + TGSI_EXEC_DATA_DOUBLE, > > > One comma too many f

Re: [Mesa-dev] [PATCH] gallium: add double opcodes and TGSI execution (v2.1)

2014-12-23 Thread Glenn Kennard
On Tue, 23 Dec 2014 22:50:30 +0100, Dave Airlie wrote: This patch adds support for a set of double opcodes to TGSI. It is an update of work done originally by Michal Krol on the gallium-double-opcodes branch. The opcodes have a hint where they came from in the header file. v2: add unsigned/in

[Mesa-dev] [PATCH] gallium: add double opcodes and TGSI execution (v2.1)

2014-12-23 Thread Dave Airlie
This patch adds support for a set of double opcodes to TGSI. It is an update of work done originally by Michal Krol on the gallium-double-opcodes branch. The opcodes have a hint where they came from in the header file. v2: add unsigned/int <-> double v2.1: update docs. This is based on code by M