Re: [Mesa-dev] [PATCH] freedreno/meson: Only build the compiler if building freedreno

2017-11-11 Thread Jason Ekstrand
On Sat, Nov 11, 2017 at 8:11 AM, Dylan Baker wrote: > I sent a patch to fix this as did Rob, I think his landed already. > Yeah... I still kind-of like the way my patch works. I personally think it's way nicer to predicate build targets on boolean configure flags rather than setting build_by_d

Re: [Mesa-dev] [PATCH] freedreno/meson: Only build the compiler if building freedreno

2017-11-11 Thread Rob Clark
hmm, well autotools build built it by default, and it's contribution to build time is negligible vs addition of even more config options.. perhaps it is really only useful for debug builds, so I'd be ok with the approach of only building it for debug builds BR, -R On Sat, Nov 11, 2017 at 11:11

Re: [Mesa-dev] [PATCH] freedreno/meson: Only build the compiler if building freedreno

2017-11-11 Thread Dylan Baker
I sent a patch to fix this as did Rob, I think his landed already. I'm not sure it's a good idea to build tools by default. Personally I'd rather see an extra option added if compiling via ninja src/gallium/drivers/freedreno/ir3compiler is too tedious. Dylan On November 10, 2017 11:10:37 PM PS

Re: [Mesa-dev] [PATCH] freedreno/meson: Only build the compiler if building freedreno

2017-11-11 Thread Rob Clark
sorry 'bout that.. this should already fix it: https://cgit.freedesktop.org/mesa/mesa/commit/?id=881f6e741fe0f63df1aa6aadba7e2eb64269cb20 On Sat, Nov 11, 2017 at 2:10 AM, Jason Ekstrand wrote: > Setting build_by_default to true makes it suddenly pull in freedreno and > all of gallium uncondition

[Mesa-dev] [PATCH] freedreno/meson: Only build the compiler if building freedreno

2017-11-10 Thread Jason Ekstrand
Setting build_by_default to true makes it suddenly pull in freedreno and all of gallium unconditionally. Cc: Rob Clark Cc: Dylan Baker --- src/gallium/drivers/freedreno/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/freedreno/meson.build b/s