Re: [Mesa-dev] [PATCH] egl_dri2: Allow both 24 and 32 bit X visuals for RGBA configs

2014-11-08 Thread Pekka Paalanen
On Fri, 07 Nov 2014 11:32:04 -0800 Eric Anholt wrote: > Pekka Paalanen writes: > > > On Thu, 06 Nov 2014 13:01:03 -0800 > > Ian Romanick wrote: > > > >> I thought Eric and Chad already NAKed it in bugzilla. The problem is > >> that applications ask for an RGBA visual for GL blending. They us

Re: [Mesa-dev] [PATCH] egl_dri2: Allow both 24 and 32 bit X visuals for RGBA configs

2014-11-07 Thread Eric Anholt
Pekka Paalanen writes: > On Thu, 06 Nov 2014 13:01:03 -0800 > Ian Romanick wrote: > >> I thought Eric and Chad already NAKed it in bugzilla. The problem is >> that applications ask for an RGBA visual for GL blending. They use the >> alpha channel to generate their images, but the final alpha v

Re: [Mesa-dev] [PATCH] egl_dri2: Allow both 24 and 32 bit X visuals for RGBA configs

2014-11-07 Thread Pekka Paalanen
On Thu, 06 Nov 2014 13:01:03 -0800 Ian Romanick wrote: > I thought Eric and Chad already NAKed it in bugzilla. The problem is > that applications ask for an RGBA visual for GL blending. They use the > alpha channel to generate their images, but the final alpha values are, > basically, random...

Re: [Mesa-dev] [PATCH] egl_dri2: Allow both 24 and 32 bit X visuals for RGBA configs

2014-11-06 Thread Ian Romanick
I thought Eric and Chad already NAKed it in bugzilla. The problem is that applications ask for an RGBA visual for GL blending. They use the alpha channel to generate their images, but the final alpha values are, basically, random... and the composited result would be pure garbage. As Chad points

Re: [Mesa-dev] [PATCH] egl_dri2: Allow both 24 and 32 bit X visuals for RGBA configs

2014-11-06 Thread Marek Olšák
If there's no feedback for so long, I suggest you commit the patch without review. If it fixes a bug, that's one more reason to commit it. Marek On Thu, Nov 6, 2014 at 2:12 PM, Emil Velikov wrote: > Humble ping x2 > > On 14/10/14 15:25, Emil Velikov wrote: >> Humble ping. >> >> On 23/09/14 01:25

Re: [Mesa-dev] [PATCH] egl_dri2: Allow both 24 and 32 bit X visuals for RGBA configs

2014-11-06 Thread Emil Velikov
Humble ping x2 On 14/10/14 15:25, Emil Velikov wrote: > Humble ping. > > On 23/09/14 01:25, Emil Velikov wrote: >> From: Sjoerd Simons >> >> When using RGBA EGLConfigs allow both RGB and RGBA X visuals, such that >> application can decide whether they want to use RGBA (and have the >> compositor

Re: [Mesa-dev] [PATCH] egl_dri2: Allow both 24 and 32 bit X visuals for RGBA configs

2014-10-14 Thread Emil Velikov
Humble ping. On 23/09/14 01:25, Emil Velikov wrote: > From: Sjoerd Simons > > When using RGBA EGLConfigs allow both RGB and RGBA X visuals, such that > application can decide whether they want to use RGBA (and have the > compositor blend their windows). > > On my system with this change EGLConf

[Mesa-dev] [PATCH] egl_dri2: Allow both 24 and 32 bit X visuals for RGBA configs

2014-09-22 Thread Emil Velikov
From: Sjoerd Simons When using RGBA EGLConfigs allow both RGB and RGBA X visuals, such that application can decide whether they want to use RGBA (and have the compositor blend their windows). On my system with this change EGLConfigs with a 24 bit visual comes up first, as such applications blind