Re: [Mesa-dev] [PATCH] egl/x11: Remove unneeded free() on always null string

2017-12-06 Thread Vadim Shovkoplias
Hi Eric, I used smatch (http://smatch.sourceforge.net/). It is mainly used for Linux kernel. 2017-12-04 18:52 GMT+02:00 Eric Engestrom : > On Monday, 2017-12-04 12:48:55 +0200, Vadim Shovkoplias wrote: > > Hi Eric, > > Hey, sorry, I forgot to hit "send" on the reply I wrote on friday :] > > > >

Re: [Mesa-dev] [PATCH] egl/x11: Remove unneeded free() on always null string

2017-12-06 Thread Vadym Shovkoplias
Hi Eric, I used smatch (http://smatch.sourceforge.net/). It is mainly used for Linux kernel. On Mon, Dec 4, 2017 at 6:52 PM, Eric Engestrom wrote: > On Monday, 2017-12-04 12:48:55 +0200, Vadim Shovkoplias wrote: > > Hi Eric, > > Hey, sorry, I forgot to hit "send" on the reply I wrote on friday

Re: [Mesa-dev] [PATCH] egl/x11: Remove unneeded free() on always null string

2017-12-04 Thread Eric Engestrom
On Monday, 2017-12-04 12:48:55 +0200, Vadim Shovkoplias wrote: > Hi Eric, Hey, sorry, I forgot to hit "send" on the reply I wrote on friday :] > > Mostly by a static analysis tool. It found at least 7 issues with useless > free() calls and other problems that probably should be fixed. What tool

Re: [Mesa-dev] [PATCH] egl/x11: Remove unneeded free() on always null string

2017-12-04 Thread Vadim Shovkoplias
Hi Eric, Mostly by a static analysis tool. It found at least 7 issues with useless free() calls and other problems that probably should be fixed. Suggest please should I create one cumulative commit for this or it should be a separate commits ? 2017-12-01 17:41 GMT+02:00 Eric Engestrom : > On Fr

Re: [Mesa-dev] [PATCH] egl/x11: Remove unneeded free() on always null string

2017-12-01 Thread Vadym Shovkoplias
Hi Eric, Mostly by a static analysis tool. It found at least 7 issues with useless free() calls and other problems that probably should be fixed. Suggest please should I create one cumulative commit for this or it should be a separate commits ? On Fri, Dec 1, 2017 at 5:41 PM, Eric Engestrom wrot

Re: [Mesa-dev] [PATCH] egl/x11: Remove unneeded free() on always null string

2017-12-01 Thread Eric Engestrom
On Friday, 2017-12-01 17:08:53 +0200, vadim.shovkopl...@gmail.com wrote: > From: Vadym Shovkoplias > > In this condition dri2_dpy->driver_name string always equals > NULL, so call to free() is useless > > Signed-off-by: Vadym Shovkoplias Reviewed and pushed :) Are you finding all of these by

[Mesa-dev] [PATCH] egl/x11: Remove unneeded free() on always null string

2017-12-01 Thread vadim . shovkoplias
From: Vadym Shovkoplias In this condition dri2_dpy->driver_name string always equals NULL, so call to free() is useless Signed-off-by: Vadym Shovkoplias --- src/egl/drivers/dri2/platform_x11.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/egl/drivers/dri2/platform_x11.c b/src/egl/dr