Re: [Mesa-dev] [PATCH] egl/wayland: Support for KHR_partial_update

2017-10-20 Thread Eric Engestrom
On Wednesday, 2017-10-18 10:20:01 +, Harish Krupo wrote: > Hi Eric, > > Eric Engestrom writes: > > > On Wednesday, 2017-10-18 06:06:45 +, Harish Krupo wrote: > >> Hi Eric, > >> > >> Eric Engestrom writes: > >> > I might need to double check the spec, but I thought "no damage hint" > >>

Re: [Mesa-dev] [PATCH] egl/wayland: Support for KHR_partial_update

2017-10-18 Thread Emil Velikov
On 17 October 2017 at 17:34, Harish Krupo wrote: > Hi Emil, > > Thank you for the comments, will fix the code accordingly and send a > v2 patch. > I have answered the question inline. > > Emil Velikov writes: > >> Hi Harish, >> >> Overall looks great, a few comments/questions inline. >> >> On 13

Re: [Mesa-dev] [PATCH] egl/wayland: Support for KHR_partial_update

2017-10-18 Thread Harish Krupo
Hi Eric, Eric Engestrom writes: > On Wednesday, 2017-10-18 06:06:45 +, Harish Krupo wrote: >> Hi Eric, >> >> Eric Engestrom writes: >> > I might need to double check the spec, but I thought "no damage hint" >> > meant "no way to reduce the update, redraw the whole screen"? >> > >> > If tha

Re: [Mesa-dev] [PATCH] egl/wayland: Support for KHR_partial_update

2017-10-18 Thread Eric Engestrom
On Wednesday, 2017-10-18 06:06:45 +, Harish Krupo wrote: > Hi Eric, > > Eric Engestrom writes: > > I might need to double check the spec, but I thought "no damage hint" > > meant "no way to reduce the update, redraw the whole screen"? > > > > If that's the case, then SwapBuffers() and SwapBuf

Re: [Mesa-dev] [PATCH] egl/wayland: Support for KHR_partial_update

2017-10-17 Thread Harish Krupo
Hi Eric, Eric Engestrom writes: > On 17 October 2017 17:36:06 BST, Harish Krupo > wrote: >> Hi Emil, >> >> Thank you for the comments, will fix the code accordingly and send a >> v2 patch. >> I have answered the question inline. >> >> Emil Velikov writes: >> >> > Hi Harish, >> > >> > Overa

Re: [Mesa-dev] [PATCH] egl/wayland: Support for KHR_partial_update

2017-10-17 Thread Eric Engestrom
On 17 October 2017 17:36:06 BST, Harish Krupo wrote: > Hi Emil, > > Thank you for the comments, will fix the code accordingly and send a > v2 patch. > I have answered the question inline. > > Emil Velikov writes: > > > Hi Harish, > > > > Overall looks great, a few comments/questions inline. >

Re: [Mesa-dev] [PATCH] egl/wayland: Support for KHR_partial_update

2017-10-17 Thread Harish Krupo
Hi Emil, Thank you for the comments, will fix the code accordingly and send a v2 patch. I have answered the question inline. Emil Velikov writes: > Hi Harish, > > Overall looks great, a few comments/questions inline. > > On 13 October 2017 at 19:49, Harish Krupo wrote: >> This passes 33/37 deq

Re: [Mesa-dev] [PATCH] egl/wayland: Support for KHR_partial_update

2017-10-17 Thread Harish Krupo
Eric Engestrom writes: > On Monday, 2017-10-16 13:54:25 +, Emil Velikov wrote: >> Hi Harish, >> >> Overall looks great, a few comments/questions inline. >> > > I agree with everything Emil said :) > >> On 13 October 2017 at 19:49, Harish Krupo wrote: >> > This passes 33/37 deqp tests rela

Re: [Mesa-dev] [PATCH] egl/wayland: Support for KHR_partial_update

2017-10-16 Thread Eric Engestrom
On Monday, 2017-10-16 13:54:25 +, Emil Velikov wrote: > Hi Harish, > > Overall looks great, a few comments/questions inline. > I agree with everything Emil said :) > On 13 October 2017 at 19:49, Harish Krupo wrote: > > This passes 33/37 deqp tests related to partial_update, 4 are not > > s

Re: [Mesa-dev] [PATCH] egl/wayland: Support for KHR_partial_update

2017-10-16 Thread Eric Engestrom
On Monday, 2017-10-16 15:37:31 +, Emil Velikov wrote: > On 16 October 2017 at 16:21, Eric Engestrom wrote: > > On Monday, 2017-10-16 14:29:02 +, Emil Velikov wrote: > >> On 13 October 2017 at 19:49, Harish Krupo > >> wrote: > >> > This passes 33/37 deqp tests related to partial_update, 4

Re: [Mesa-dev] [PATCH] egl/wayland: Support for KHR_partial_update

2017-10-16 Thread Emil Velikov
On 16 October 2017 at 16:21, Eric Engestrom wrote: > On Monday, 2017-10-16 14:29:02 +, Emil Velikov wrote: >> On 13 October 2017 at 19:49, Harish Krupo wrote: >> > This passes 33/37 deqp tests related to partial_update, 4 are not >> > supported. >> > >> Mildly related: >> Android's .swap_buff

Re: [Mesa-dev] [PATCH] egl/wayland: Support for KHR_partial_update

2017-10-16 Thread Eric Engestrom
On Monday, 2017-10-16 14:29:02 +, Emil Velikov wrote: > On 13 October 2017 at 19:49, Harish Krupo wrote: > > This passes 33/37 deqp tests related to partial_update, 4 are not > > supported. > > > Mildly related: > Android's .swap_buffers_with_damage seems to be missing. AFAICT should > be able

Re: [Mesa-dev] [PATCH] egl/wayland: Support for KHR_partial_update

2017-10-16 Thread Emil Velikov
On 13 October 2017 at 19:49, Harish Krupo wrote: > This passes 33/37 deqp tests related to partial_update, 4 are not > supported. > Mildly related: Android's .swap_buffers_with_damage seems to be missing. AFAICT should be able to implement it via droid_set_damage_region? Speaking of which: One co

Re: [Mesa-dev] [PATCH] egl/wayland: Support for KHR_partial_update

2017-10-16 Thread Emil Velikov
Hi Harish, Overall looks great, a few comments/questions inline. On 13 October 2017 at 19:49, Harish Krupo wrote: > This passes 33/37 deqp tests related to partial_update, 4 are not > supported. > > Signed-off-by: Harish Krupo > --- > src/egl/drivers/dri2/platform_wayland.c | 68 > +++

[Mesa-dev] [PATCH] egl/wayland: Support for KHR_partial_update

2017-10-13 Thread Harish Krupo
This passes 33/37 deqp tests related to partial_update, 4 are not supported. Signed-off-by: Harish Krupo --- src/egl/drivers/dri2/platform_wayland.c | 68 - 1 file changed, 59 insertions(+), 9 deletions(-) diff --git a/src/egl/drivers/dri2/platform_wayland.c b/s