Re: [Mesa-dev] [PATCH] egl/drm: Try to use CLOEXEC for drm fds

2015-06-12 Thread Derek Foreman
On 12/06/15 05:52 PM, Emil Velikov wrote: > On 12/06/15 19:05, Derek Foreman wrote: >> On 12/06/15 11:29 AM, Emil Velikov wrote: >>> Hi Derek, >> >> Hi, thanks for looking at this. :) >> > Props goes to Matt, for the reminder. It kind of fell of my radar. > >>> On 1 May 2015 at 18:34, Derek Forema

Re: [Mesa-dev] [PATCH] egl/drm: Try to use CLOEXEC for drm fds

2015-06-12 Thread Emil Velikov
On 12/06/15 19:05, Derek Foreman wrote: > On 12/06/15 11:29 AM, Emil Velikov wrote: >> Hi Derek, > > Hi, thanks for looking at this. :) > Props goes to Matt, for the reminder. It kind of fell of my radar. >> On 1 May 2015 at 18:34, Derek Foreman wrote: >>> These fds can propagate to child proce

Re: [Mesa-dev] [PATCH] egl/drm: Try to use CLOEXEC for drm fds

2015-06-12 Thread Derek Foreman
On 12/06/15 11:29 AM, Emil Velikov wrote: > Hi Derek, Hi, thanks for looking at this. :) > On 1 May 2015 at 18:34, Derek Foreman wrote: >> These fds can propagate to child processes if we don't set CLOEXEC, >> so make a best effort to do that. >> >> Signed-off-by: Derek Foreman >> --- >> Notice

Re: [Mesa-dev] [PATCH] egl/drm: Try to use CLOEXEC for drm fds

2015-06-12 Thread Emil Velikov
Hi Derek, On 1 May 2015 at 18:34, Derek Foreman wrote: > These fds can propagate to child processes if we don't set CLOEXEC, > so make a best effort to do that. > > Signed-off-by: Derek Foreman > --- > Noticed this when fixing up similar problems in weston - weston's > drm fd gets dup()ed here a

[Mesa-dev] [PATCH] egl/drm: Try to use CLOEXEC for drm fds

2015-05-01 Thread Derek Foreman
These fds can propagate to child processes if we don't set CLOEXEC, so make a best effort to do that. Signed-off-by: Derek Foreman --- Noticed this when fixing up similar problems in weston - weston's drm fd gets dup()ed here and loses CLOEXEC and ends up in every child process the shell launches