Re: [Mesa-dev] [PATCH] draw: don't set start_instance and instance id for pt emit

2015-12-16 Thread Jose Fonseca
On 15/12/15 00:58, srol...@vmware.com wrote: From: Roland Scheidegger This just adds confusion, these parameters are used when fetching vertices by translate, but certainly not when emitting hw vertices for drivers, they make no sense there (setting them has no consequences otherwise since ther

Re: [Mesa-dev] [PATCH] draw: don't set start_instance and instance id for pt emit

2015-12-14 Thread Brian Paul
Just one minor nit below. Reviewed-by: Brian Paul On 12/14/2015 05:58 PM, srol...@vmware.com wrote: From: Roland Scheidegger This just adds confusion, these parameters are used when fetching vertices by translate, but certainly not when emitting hw vertices for drivers, they make no sense t

[Mesa-dev] [PATCH] draw: don't set start_instance and instance id for pt emit

2015-12-14 Thread sroland
From: Roland Scheidegger This just adds confusion, these parameters are used when fetching vertices by translate, but certainly not when emitting hw vertices for drivers, they make no sense there (setting them has no consequences otherwise since there won't be any elements with instance_divisor s